Clean the SingletonLock only if there is no previous Chromium process running.

Clean the SingletonLock only if there is no previous Chromium process running.

BUG=96134
TEST=Launch three Chrome processes to see that the third one doesn't crash.

Patch by amruthraj@motorola.com

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100943

[jam, 2011-09-12 16:34:01]

I'm not familiar with this code at all, so I'm not a good reviewer for this.

[tony, 2011-09-12 17:11:43]

LGTM.  I see that you signed the CLA too.  Thanks!

Is this a recent regression from the browser_main refactoring?

[tony, 2011-09-12 17:18:08]

On 2011/09/12 17:11:43, tony wrote:
> LGTM.  I see that you signed the CLA too.  Thanks!
> 
> Is this a recent regression from the browser_main refactoring?

Yes, it looks like this was regressed by http://codereview.chromium.org/7840041.
 Previously, we would exit chrome when returning from BrowserMain, but now we
always run PostMainMessageLoopRun, which runs the cleanup code.

[jam, 2011-09-12 17:28:10]

ah, ok now I see where my refactoring changed things, thanks for the fix. lgtm

http://codereview.chromium.org/7796030/diff/2001/chrome/browser/chrome_browse...
File chrome/browser/chrome_browser_main.cc (right):

http://codereview.chromium.org/7796030/diff/2001/chrome/browser/chrome_browse...
chrome/browser/chrome_browser_main.cc:1885: if (notify_result_ ==
ProcessSingleton::PROCESS_NONE) {
nit: the rest of the file doesn't use brace brackets for single line statements

[amruthraj, 2011-09-13 03:52:15]

On 2011/09/12 17:28:10, John Abd-El-Malek wrote:
> ah, ok now I see where my refactoring changed things, thanks for the fix. lgtm
> 
>
http://codereview.chromium.org/7796030/diff/2001/chrome/browser/chrome_browse...
> File chrome/browser/chrome_browser_main.cc (right):
> 
>
http://codereview.chromium.org/7796030/diff/2001/chrome/browser/chrome_browse...
> chrome/browser/chrome_browser_main.cc:1885: if (notify_result_ ==
> ProcessSingleton::PROCESS_NONE) {
> nit: the rest of the file doesn't use brace brackets for single line
statements
Done.

[jam, 2011-09-13 16:56:34]

lgtm (you don't need to wait for another lgtm if I gave one earlier with nits,
and you take care of the nits)

[commit-bot: I haz the power, 2011-09-13 18:53:43]

Change committed as 100943

[Amruth Raj, 2011-10-17 14:19:04]

On 2011/09/13 18:53:43, I haz the power (commit-bot) wrote:
> Change committed as 100943

Done