Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(473)

Unified Diff: remoting/protocol/session.h

Issue 7796026: Pass SessionConfig by reference instead of pointer. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: remoting/protocol/session.h
diff --git a/remoting/protocol/session.h b/remoting/protocol/session.h
index 73b85c8effb69bcd7abc65d356b22a70277578c8..252b24c31398d5e2b452cd350e87d4da09e17306 100644
--- a/remoting/protocol/session.h
+++ b/remoting/protocol/session.h
@@ -87,13 +87,13 @@ class Session : public base::NonThreadSafe {
// Protocol configuration. Can be called only after session has been accepted.
// Returned pointer is valid until connection is closed.
- virtual const SessionConfig* config() = 0;
+ virtual const SessionConfig& config() = 0;
// Set protocol configuration for an incoming session. Must be called
// on the host before the connection is accepted, from
// ChromotocolServer::IncomingConnectionCallback. Ownership of |config| is
Wez 2011/09/10 01:04:29 nit: This comment is out-of-date; consider updatin
Sergey Ulanov 2011/09/10 06:45:58 Done.
// given to the connection.
- virtual void set_config(const SessionConfig* config) = 0;
+ virtual void set_config(const SessionConfig& config) = 0;
// The raw auth tokens from the session-initiate, or session-accept stanzas.
virtual const std::string& initiator_token() = 0;

Powered by Google App Engine
This is Rietveld 408576698