Don't interpret embeded NULLs in a response header line as a line terminator.

net/http/http_response_headers.cc

Index: net/http/http_response_headers.cc
===================================================================
--- net/http/http_response_headers.cc	(revision 100022)
+++ net/http/http_response_headers.cc	(working copy)
@@ -114,6 +114,13 @@
   return 0;
 }
 
+void CheckDoesNotHaveEmbededNulls(const std::string& str) {
+  // Care needs to be taken when adding values to the raw headers string to
+  // make sure it does not contain embeded NULLs. Any embeded \0 may be

[wtc, 2011/09/12 18:48:09]

Nit: \0 => '\0'

     may be => is

[eroman, 2011/09/12 21:19:24]

Done.

+  // understood as line terminators and change how header lines get tokenized.
+  CHECK(str.find('\0') == std::string::npos);
+}
+
 }  // namespace
 
 struct HttpResponseHeaders::ParsedHeader {
@@ -300,6 +307,7 @@
 }
 
 void HttpResponseHeaders::AddHeader(const std::string& header) {
+  CheckDoesNotHaveEmbededNulls(header);
   DCHECK_EQ('\0', raw_headers_[raw_headers_.size() - 2]);
   DCHECK_EQ('\0', raw_headers_[raw_headers_.size() - 1]);
   // Don't copy the last null.
@@ -315,6 +323,7 @@
 }
 
 void HttpResponseHeaders::ReplaceStatusLine(const std::string& new_status) {
+  CheckDoesNotHaveEmbededNulls(new_status);
   // Copy up to the null byte.  This just copies the status line.
   std::string new_raw_headers(new_status);
   new_raw_headers.push_back('\0');