Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(307)

Issue 7796025: Don't interpret embeded NULLs in a response header line as a line terminator. (Closed)

Created:
9 years, 3 months ago by eroman
Modified:
9 years, 3 months ago
CC:
chromium-reviews, cbentzel+watch_chromium.org, darin-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Don't interpret embeded NULLs in a response header line as a line terminator. BUG=95992 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100863

Patch Set 1 #

Total comments: 10

Patch Set 2 : Address wtc comments #

Unified diffs Side-by-side diffs Delta from patch set Stats (+45 lines, -9 lines) Patch
M net/http/http_response_headers.h View 1 1 chunk +0 lines, -3 lines 0 comments Download
M net/http/http_response_headers.cc View 1 3 chunks +9 lines, -0 lines 0 comments Download
M net/http/http_util.h View 1 1 chunk +8 lines, -0 lines 0 comments Download
M net/http/http_util.cc View 1 2 chunks +10 lines, -2 lines 0 comments Download
M net/http/http_util_unittest.cc View 1 2 chunks +18 lines, -4 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
eroman
9 years, 3 months ago (2011-09-09 23:28:49 UTC) #1
wtc
LGTM. http://codereview.chromium.org/7796025/diff/1/net/http/http_response_headers.cc File net/http/http_response_headers.cc (right): http://codereview.chromium.org/7796025/diff/1/net/http/http_response_headers.cc#newcode119 net/http/http_response_headers.cc:119: // make sure it does not contain embeded ...
9 years, 3 months ago (2011-09-12 18:48:08 UTC) #2
eroman
thanks for the review. http://codereview.chromium.org/7796025/diff/1/net/http/http_response_headers.cc File net/http/http_response_headers.cc (right): http://codereview.chromium.org/7796025/diff/1/net/http/http_response_headers.cc#newcode119 net/http/http_response_headers.cc:119: // make sure it does ...
9 years, 3 months ago (2011-09-12 21:19:24 UTC) #3
commit-bot: I haz the power
9 years, 3 months ago (2011-09-13 04:55:20 UTC) #4
Change committed as 100863

Powered by Google App Engine
This is Rietveld 408576698