Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1202)

Issue 7796015: Revert 100494 - Revert "Revert 100453 - Revert "Revert 100384 - Fix bug in SimulateAttrib0."" (Closed)

Created:
9 years, 3 months ago by dmichael (off chromium)
Modified:
9 years, 3 months ago
Reviewers:
greggman
CC:
chromium-reviews, apatrick_chromium, Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 100494 - Revert "Revert 100453 - Revert "Revert 100384 - Fix bug in SimulateAttrib0."" The bug was a unsigned->signed conversion issue. Clang truncates, gcc/vc overflow TEST=unit tests BUG=95625 TBR=apatrick@chromium.org Review URL: http://codereview.chromium.org/7863007 TBR=gman@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100498

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+42 lines, -137 lines) Patch
M gpu/command_buffer/service/gles2_cmd_decoder.cc View 8 chunks +24 lines, -61 lines 0 comments Download
M gpu/command_buffer/service/gles2_cmd_decoder_unittest.cc View 3 chunks +18 lines, -76 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
dmichael (off chromium)
9 years, 3 months ago (2011-09-09 21:23:40 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698