chrome/browser/ui/webui/downloads_dom_handler.cc - Issue 7796014: Make cancel remove cancelled download from active queues at time of cancel.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/downloads_dom_handler.cc

Issue 7796014: Make cancel remove cancelled download from active queues at time of cancel. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Final Cancel arg fix. Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/webui/chromeos/imageburner/imageburner_ui.cc ('k') | chrome/test/data/download-dangerous.jar » ('j') | content/browser/download/download_item.h » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/downloads_dom_handler.cc

diff --git a/chrome/browser/ui/webui/downloads_dom_handler.cc b/chrome/browser/ui/webui/downloads_dom_handler.cc

index 52e986c46d29d884b1a400e63df23bc3e36cb69a..5f74dd2356393d4f764426e904a640b3dacce4e8 100644

--- a/chrome/browser/ui/webui/downloads_dom_handler.cc

+++ b/chrome/browser/ui/webui/downloads_dom_handler.cc

@@ -314,7 +314,7 @@ void DownloadsDOMHandler::HandleCancel(const ListValue* args) {

CountDownloadsDOMEvents(DOWNLOADS_DOM_EVENT_CANCEL);

DownloadItem* file = GetDownloadByValue(args);

if (file)

- file->Cancel(true);

+ file->Cancel();

}

void DownloadsDOMHandler::HandleClearAll(const ListValue* args) {