Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(763)

Unified Diff: chrome/browser/ui/views/infobars/after_translate_infobar.h

Issue 7796010: Attempt at fixing crash in menus shown from infobars. Here's what the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: ignore return value Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/after_translate_infobar.h
diff --git a/chrome/browser/ui/views/infobars/after_translate_infobar.h b/chrome/browser/ui/views/infobars/after_translate_infobar.h
index 443e60e66cba68168e60ce274d6f69338b708714..bf2688198144ab41a55147915382b0a9ace150f9 100644
--- a/chrome/browser/ui/views/infobars/after_translate_infobar.h
+++ b/chrome/browser/ui/views/infobars/after_translate_infobar.h
@@ -14,7 +14,6 @@
class TranslateInfoBarDelegate;
namespace views {
class MenuButton;
-class MenuRunner;
}
class AfterTranslateInfoBar : public TranslateInfoBarBase,
@@ -27,15 +26,18 @@ class AfterTranslateInfoBar : public TranslateInfoBarBase,
virtual ~AfterTranslateInfoBar();
// TranslateInfoBarBase:
- virtual void Layout();
- virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
- virtual void ButtonPressed(views::Button* sender, const views::Event& event);
- virtual int ContentMinimumWidth() const;
- virtual void OriginalLanguageChanged();
- virtual void TargetLanguageChanged();
+ virtual void Layout() OVERRIDE;
+ virtual void ViewHierarchyChanged(bool is_add,
+ View* parent,
+ View* child) OVERRIDE;
+ virtual void ButtonPressed(views::Button* sender,
+ const views::Event& event) OVERRIDE;
+ virtual int ContentMinimumWidth() const OVERRIDE;
+ virtual void OriginalLanguageChanged() OVERRIDE;
+ virtual void TargetLanguageChanged() OVERRIDE;
// ViewMenuDelegate:
- virtual void RunMenu(View* source, const gfx::Point& pt);
+ virtual void RunMenu(View* source, const gfx::Point& pt) OVERRIDE;
// The text displayed in the infobar is something like:
// "Translated from <lang1> to <lang2> [more text in some languages]"
@@ -54,8 +56,6 @@ class AfterTranslateInfoBar : public TranslateInfoBarBase,
LanguagesMenuModel target_language_menu_model_;
OptionsMenuModel options_menu_model_;
- scoped_ptr<views::MenuRunner> menu_runner_;
-
// True if the target language comes before the original one.
bool swapped_language_buttons_;

Powered by Google App Engine
This is Rietveld 408576698