Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(900)

Unified Diff: chrome/browser/ui/views/infobars/before_translate_infobar.h

Issue 7796010: Attempt at fixing crash in menus shown from infobars. Here's what the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Change comment and remove change to views Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/before_translate_infobar.h
diff --git a/chrome/browser/ui/views/infobars/before_translate_infobar.h b/chrome/browser/ui/views/infobars/before_translate_infobar.h
index f7e0ad0a4e0f2855878257b6acecf8c82744a223..18d212546a2c898a456360c15b98cb3a5f862e8a 100644
--- a/chrome/browser/ui/views/infobars/before_translate_infobar.h
+++ b/chrome/browser/ui/views/infobars/before_translate_infobar.h
@@ -14,7 +14,6 @@
class TranslateInfoBarDelegate;
namespace views {
class MenuButton;
-class MenuRunner;
}
class BeforeTranslateInfoBar : public TranslateInfoBarBase,
@@ -27,14 +26,17 @@ class BeforeTranslateInfoBar : public TranslateInfoBarBase,
virtual ~BeforeTranslateInfoBar();
// TranslateInfoBarBase:
- virtual void Layout();
- virtual void ButtonPressed(views::Button* sender, const views::Event& event);
- virtual void ViewHierarchyChanged(bool is_add, View* parent, View* child);
- virtual int ContentMinimumWidth() const;
- virtual void OriginalLanguageChanged();
+ virtual void Layout() OVERRIDE;
+ virtual void ButtonPressed(views::Button* sender,
+ const views::Event& event) OVERRIDE;
+ virtual void ViewHierarchyChanged(bool is_add,
+ View* parent,
+ View* child) OVERRIDE;
+ virtual int ContentMinimumWidth() const OVERRIDE;
+ virtual void OriginalLanguageChanged() OVERRIDE;
// views::ViewMenuDelegate:
- virtual void RunMenu(View* source, const gfx::Point& pt);
+ virtual void RunMenu(View* source, const gfx::Point& pt) OVERRIDE;
// The text displayed in the infobar is something like:
// "The page is in <lang>. Would you like to translate it?"
@@ -53,8 +55,6 @@ class BeforeTranslateInfoBar : public TranslateInfoBarBase,
LanguagesMenuModel languages_menu_model_;
OptionsMenuModel options_menu_model_;
- scoped_ptr<views::MenuRunner> menu_runner_;
-
DISALLOW_COPY_AND_ASSIGN(BeforeTranslateInfoBar);
};

Powered by Google App Engine
This is Rietveld 408576698