Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(383)

Unified Diff: chrome/browser/ui/views/infobars/infobar_view.h

Issue 7796010: Attempt at fixing crash in menus shown from infobars. Here's what the (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/infobars/infobar_view.h
diff --git a/chrome/browser/ui/views/infobars/infobar_view.h b/chrome/browser/ui/views/infobars/infobar_view.h
index 75d87605cd3c9759f3cd7eee27308905f8322ab4..72979d90fadab31b6e1a9a5c9d769a2d5f0c1e3f 100644
--- a/chrome/browser/ui/views/infobars/infobar_view.h
+++ b/chrome/browser/ui/views/infobars/infobar_view.h
@@ -83,6 +83,11 @@ class InfoBarView : public InfoBar,
// Convenience getter.
const InfoBarContainer::Delegate* container_delegate() const;
+ // Subclasses must override and cancel any menus. Because we are deleted after
+ // a delay and after our delegate is deleted we have to explicitly cancel the
+ // menu rather than relying on the destructor to cancel the menu.
+ virtual void CancelMenu() = 0;
Peter Kasting 2011/09/12 18:06:00 Nit: I would prefer to not make this pure virtual.
+
private:
static const int kHorizontalPadding;

Powered by Google App Engine
This is Rietveld 408576698