gclient.py - Issue 7795061: Remove gclient_utils.Popen() usage from gclient.py

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: gclient.py

Issue 7795061: Remove gclient_utils.Popen() usage from gclient.py (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/tools/depot_tools

Patch Set: Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: gclient.py

diff --git a/gclient.py b/gclient.py

index 69b524c3233ee034a0d7ddcc78141097e1d0c591..ef77cd4b73cc13fe352bc5d7afad2da9fdb17388 100644

--- a/gclient.py

+++ b/gclient.py

@@ -1000,7 +1000,7 @@ def CMDrecurse(parser, args):

env['GCLIENT_SCM'] = scm

if url:

env['GCLIENT_URL'] = url

- gclient_utils.Popen(args, cwd=cwd, env=env).communicate()

+ subprocess2.call(args, cwd=cwd, env=env)

return 0

« no previous file with comments | « no previous file | no next file » | no next file with comments »