Make integer indexed properties ("elements") work for proxies.

Make integer indexed properties ("elements") work for proxies.
Rehome some Object/JSReceiver/JSObject methods.

R=ricow@chromium.org,kmillikin@chromium.org
BUG=v8:1543
TEST=

Committed: http://code.google.com/p/v8/source/detail?r=9381

[Rico, 2011-09-12 11:21:17]

LGTM

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2301
src/objects.cc:2301: "getOwnPropertyDescriptor", Handle<Object>(),
ARRAY_SIZE(args), args);
4 space indention

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2307
src/objects.cc:2307: Handle<String> getter_name =
We might as well lookup the setter first, and then only lookup the getter if the
setter is not found

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2326
src/objects.cc:2326: "setter_must_be_callable", HandleVector(args,
ARRAY_SIZE(args)));
4 space indention

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2372
src/objects.cc:2372: uint32_t index, DeleteMode mode) {
parameters on separate lines to be consistent

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2426
src/objects.cc:2426: if (!maybe->To<String>(&name)) return NONE;
Why do we return NONE here if allocation fails?

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2539
src/objects.cc:2539: /*
If this code is not needed anymore please delete it

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode8713
src/objects.cc:8713: ? JSProxy::cast(this)->SetElementWithHandler(index, value,
strict_mode)
4 space indention

http://codereview.chromium.org/7795055/diff/3001/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/7795055/diff/3001/src/objects.h#newcode6624
src/objects.h:6624: MUST_USE_RESULT MaybeObject*
SetPropertyWithHandlerDefiningSetter(
I am not to happy with this name since we don't know if there is a setter when
we call it. At least add a comment here explaining what this method does (I
can't really come up with a better name)

http://codereview.chromium.org/7795055/diff/3001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7795055/diff/3001/src/runtime.cc#newcode4512
src/runtime.cc:4512: if (args[0]->IsJSReceiver()) {
Do we ever get here with something other than a JSReceiver?
If not just do a CONVERT_CHECKED(JSReceiver, ...)

[rossberg, 2011-09-13 16:10:24]

PTAL

I have added a call to to_complete_object_descriptor that was missing before,
and added a couple of test cases.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2301
src/objects.cc:2301: "getOwnPropertyDescriptor", Handle<Object>(),
ARRAY_SIZE(args), args);
On 2011/09/12 11:21:18, Rico wrote:
> 4 space indention 

Done.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2307
src/objects.cc:2307: Handle<String> getter_name =
On 2011/09/12 11:21:18, Rico wrote:
> We might as well lookup the setter first, and then only lookup the getter if
the
> setter is not found

Done.

I also forgot to invoke ToCompletePropertyDescriptor, as the Proxy spec
requires.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2326
src/objects.cc:2326: "setter_must_be_callable", HandleVector(args,
ARRAY_SIZE(args)));
On 2011/09/12 11:21:18, Rico wrote:
> 4 space indention

Done.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2372
src/objects.cc:2372: uint32_t index, DeleteMode mode) {
On 2011/09/12 11:21:18, Rico wrote:
> parameters on separate lines to be consistent

Done.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2426
src/objects.cc:2426: if (!maybe->To<String>(&name)) return NONE;
On 2011/09/12 11:21:18, Rico wrote:
> Why do we return NONE here if allocation fails?

Fixed by introducing a factory method.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode2539
src/objects.cc:2539: /*
On 2011/09/12 11:21:18, Rico wrote:
> If this code is not needed anymore please delete it

Oops.

http://codereview.chromium.org/7795055/diff/3001/src/objects.cc#newcode8713
src/objects.cc:8713: ? JSProxy::cast(this)->SetElementWithHandler(index, value,
strict_mode)
On 2011/09/12 11:21:18, Rico wrote:
> 4 space indention 

Done.

http://codereview.chromium.org/7795055/diff/3001/src/objects.h
File src/objects.h (right):

http://codereview.chromium.org/7795055/diff/3001/src/objects.h#newcode6624
src/objects.h:6624: MUST_USE_RESULT MaybeObject*
SetPropertyWithHandlerDefiningSetter(
On 2011/09/12 11:21:18, Rico wrote:
> I am not to happy with this name since we don't know if there is a setter when
> we call it. At least add a comment here explaining what this method does (I
> can't really come up with a better name)

Done. Also changed the name to SetPropertyWithHandlerIfDefiningSetter, although
I'm not sure that's any better...

http://codereview.chromium.org/7795055/diff/3001/src/runtime.cc
File src/runtime.cc (right):

http://codereview.chromium.org/7795055/diff/3001/src/runtime.cc#newcode4512
src/runtime.cc:4512: if (args[0]->IsJSReceiver()) {
On 2011/09/12 11:21:18, Rico wrote:
> Do we ever get here with something other than a JSReceiver?
> If not just do a CONVERT_CHECKED(JSReceiver, ...)

Good question. It seems like not, so I changed it.

[Rico, 2011-09-14 11:26:50]

LGTM

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc#newcode2320
src/objects.cc:2320: Handle<Object> args[] = { Handle<Object>(proxy->handler()),
proxy, hname };
Long line

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc#newcode2417
src/objects.cc:2417: Handle<String> enum_name =
isolate->factory()->LookupAsciiSymbol("enumerable_");
Long line

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc#newcode2420
src/objects.cc:2420: Handle<String> conf_name =
isolate->factory()->LookupAsciiSymbol("configurable_");
Long line

[rossberg, 2011-09-15 09:00:12]

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc
File src/objects.cc (right):

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc#newcode2320
src/objects.cc:2320: Handle<Object> args[] = { Handle<Object>(proxy->handler()),
proxy, hname };
On 2011/09/14 11:26:50, Rico wrote:
> Long line

Done.

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc#newcode2417
src/objects.cc:2417: Handle<String> enum_name =
isolate->factory()->LookupAsciiSymbol("enumerable_");
On 2011/09/14 11:26:50, Rico wrote:
> Long line

Done.

http://codereview.chromium.org/7795055/diff/14001/src/objects.cc#newcode2420
src/objects.cc:2420: Handle<String> conf_name =
isolate->factory()->LookupAsciiSymbol("configurable_");
On 2011/09/14 11:26:50, Rico wrote:
> Long line

Done.