src/mips/code-stubs-mips.cc - Issue 7795018: Generated code for substring slices in x64 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/mips/code-stubs-mips.cc

Issue 7795018: Generated code for substring slices in x64 and arm. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Applied Bill's suggestions. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/mips/code-stubs-mips.cc

diff --git a/src/mips/code-stubs-mips.cc b/src/mips/code-stubs-mips.cc

index 5f4c9b4e41117133ced7a89d1f59e4d217e22ebd..d574f8eed8cc6fe9b72fa329a3167f288ec937ec 100644

--- a/src/mips/code-stubs-mips.cc

+++ b/src/mips/code-stubs-mips.cc

@@ -5062,7 +5062,8 @@ void StringCharCodeAtGenerator::GenerateFast(MacroAssembler* masm) {

// Check for 1-byte or 2-byte string.

__ bind(&flat_string);

- STATIC_ASSERT(kAsciiStringTag != 0);

+ STATIC_ASSERT((kStringEncodingMask & kAsciiStringTag) != 0);

+ STATIC_ASSERT((kStringEncodingMask & kTwoByteStringTag) == 0);

__ And(t0, result_, Operand(kStringEncodingMask));

__ Branch(&ascii_string, ne, t0, Operand(zero_reg));

« no previous file with comments | « src/ia32/macro-assembler-ia32.cc ('k') | src/x64/code-stubs-x64.cc » ('j') | no next file with comments »