src/arm/lithium-codegen-arm.cc - Issue 7795018: Generated code for substring slices in x64 and arm.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: src/arm/lithium-codegen-arm.cc

Issue 7795018: Generated code for substring slices in x64 and arm. (Closed) Base URL: https://v8.googlecode.com/svn/branches/bleeding_edge

Patch Set: Applied Bill's suggestions. Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: src/arm/lithium-codegen-arm.cc

diff --git a/src/arm/lithium-codegen-arm.cc b/src/arm/lithium-codegen-arm.cc

index 976576be6f4cc1a8ce932e14369f034d60bfc09c..03ea929d88ffb0fde58ccf6f718cd48997501e89 100644

--- a/src/arm/lithium-codegen-arm.cc

+++ b/src/arm/lithium-codegen-arm.cc

@@ -3509,7 +3509,8 @@ void LCodeGen::DoStringCharCodeAt(LStringCharCodeAt* instr) {

// Dispatch on the encoding: ASCII or two-byte.

Label ascii_string;

- STATIC_ASSERT(kAsciiStringTag != 0);

+ STATIC_ASSERT((kStringEncodingMask & kAsciiStringTag) != 0);

+ STATIC_ASSERT((kStringEncodingMask & kTwoByteStringTag) == 0);

__ tst(result, Operand(kStringEncodingMask));

__ b(ne, &ascii_string);

« no previous file with comments | « src/arm/code-stubs-arm.cc ('k') | src/arm/macro-assembler-arm.h » ('j') | no next file with comments »