Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(739)

Issue 7795016: Merge 98758 - [Sync] Gracefully handle writing to a node when the cryptographer is not ready. (Closed)

Created:
9 years, 3 months ago by Nicolas Zea
Modified:
9 years, 3 months ago
Reviewers:
Nicolas Zea
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 98758 - [Sync] Gracefully handle writing to a node when the cryptographer is not ready. Due to allowing users to configure without a passphrase if they don't have passwords enabled, we can get into a situation where we require encryption of datatypes, but don't have the cryptographer enabled. When in this situation we need to ensure we don't corrupt any data. Once the user sets their passphrase, we will reencrypt everything, which will overwrite unsynced entries with their encrypted versions, allowing the sync cycle to finish. BUG=93100 TEST=sync_unit_tests --gtest_filter="*GetCommitIdsFilterEntries*" Also to manually test: set up sync on a machine with an explicit passphrase. Set up sync without passwords enabled on a separate machine and don't enter the passphrase. Enable encryption on the first client. Attempt to add a bookmark on the second client. Review URL: http://codereview.chromium.org/7795002 TBR=zea@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98770

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+176 lines, -24 lines) Patch
M chrome/browser/sync/engine/get_commit_ids_command.h View 2 chunks +8 lines, -1 line 0 comments Download
M chrome/browser/sync/engine/get_commit_ids_command.cc View 3 chunks +43 lines, -0 lines 0 comments Download
M chrome/browser/sync/engine/syncapi.cc View 5 chunks +12 lines, -15 lines 0 comments Download
M chrome/browser/sync/engine/syncer_unittest.cc View 1 chunk +49 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/nigori_util.h View 2 chunks +15 lines, -0 lines 0 comments Download
M chrome/browser/sync/syncable/nigori_util.cc View 1 chunk +18 lines, -8 lines 0 comments Download
M chrome/browser/sync/syncable/nigori_util_unittest.cc View 2 chunks +31 lines, -0 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nicolas Zea
9 years, 3 months ago (2011-08-30 03:21:50 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698