chrome/browser/resources/options/extension_settings.html - Issue 7794023: Convert chrome://extensions to a settings page within the options pages.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: chrome/browser/resources/options/extension_settings.html

Issue 7794023: Convert chrome://extensions to a settings page within the options pages. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/

Patch Set: '' Created 9 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

« chrome/browser/resources/options/extension_settings.css ('K') | « chrome/browser/resources/options/extension_settings.css ('k') | chrome/browser/resources/options/extension_settings.js » ('j') | chrome/browser/resources/options/extension_settings.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Property Changes:

Added: svn:eol-style
+ LF

OLD	NEW
(Empty)
	1 <div id="extension-settings" class="page" hidden>

	2 <h1 i18n-content="extensionSettingsTitle"></h1>

	3 <div id="dev-toggle">

	4 <input id="toggle-dev-on" type="checkbox" value="off"></input>

	5 <label title="Toggle developer mode" for="toggle-dev-on"
	csilv 2011/09/01 19:52:53 The title should be localized. Instead of this at The title should be localized. Instead of this attribute, use: i18n-values="title:toggleDeveloperMode" Finnur 2011/09/02 13:58:47 This tooltip is kind of useless and obvious. Remov This tooltip is kind of useless and obvious. Removed. On 2011/09/01 19:52:53, csilv wrote: Show quoted text > The title should be localized. Instead of this attribute, use: > i18n-values="title:toggleDeveloperMode"
	6 i18n-content="developerMode" />

	7 </div>

	8 <div class="displaytable">

	9 <div id="dev" class="dev-closed">

	10 <table id="dev-table" width="100%">

	11 <tr>

	12 <td>

	13 <button id="load-unpacked">Load unpacked extension...</button>
	csilv 2011/09/01 19:52:53 Use i18n-content to localize strings, here and bel Use i18n-content to localize strings, here and below. Finnur 2011/09/02 13:58:47 Ah, good catch! On 2011/09/01 19:52:53, csilv wro Ah, good catch! On 2011/09/01 19:52:53, csilv wrote: Show quoted text > Use i18n-content to localize strings, here and below.
	14 <button id="pack-extension">Pack extension...</button>

	15 </td>

	16 <td align="right">

	17 <button id="update-extensions-now">Update extension now</button>

	18 </td>

	19 </tr>

	20 </table>

	21 </div>

	22 <section class="content">

	23 <div class="extension-settings">

	24 <list class="big-list" id="extension-settings-list"></list>

	25 </div>

	26 </section>

	27 </div>

	28 <section>

	29 <div><strong id="no-extensions"
	csilv 2011/09/01 19:52:53 set the 'hidden' attribute rather than the style t set the 'hidden' attribute rather than the style tag. Finnur 2011/09/02 13:58:47 Done. Show quoted text On 2011/09/01 19:52:53, csilv wrote: > set the 'hidden' attribute rather than the style tag. Done.
	30 i18n-content="noExtensions"

	31 style="display: none"></strong></div>

	32 <div id="suggest-gallery" style="display: none"></div>

	33 <div id="get-more-extensions-container">

	34 <image src="chrome://theme/IDR_WEBSTORE_ICON_32" />
	csilv 2011/09/01 19:52:53 don't need the trailing slash for image tags w/ HT don't need the trailing slash for image tags w/ HTML5. Finnur 2011/09/02 13:58:47 Done. Show quoted text On 2011/09/01 19:52:53, csilv wrote: > don't need the trailing slash for image tags w/ HTML5. Done. arv (Not doing code reviews) 2011/09/06 20:55:47 <img> <image> is an IE compat quirk <img> <image> is an IE compat quirk
	35 <div id="get-more-extensions"></div>

	36 </div>

	37 </section>

	38 </div>

OLD	NEW