Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(254)

Issue 7794011: Add new test for top extension adblock crash (Closed)

Created:
9 years, 3 months ago by vivianz
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Add new test for top extension adblock crash Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=100263

Patch Set 1 #

Total comments: 4

Patch Set 2 : '' #

Patch Set 3 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+14 lines, -0 lines) Patch
A data/extensions/adblock.crx View Binary file 0 comments Download
M functional/extensions.py View 1 2 1 chunk +14 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
vivianz
9 years, 3 months ago (2011-08-29 23:12:24 UTC) #1
Nirnimesh
LGTM with nits. Please watch the bots after you commit. Thanks http://codereview.chromium.org/7794011/diff/1/functional/extensions.py File functional/extensions.py (right): ...
9 years, 3 months ago (2011-08-31 08:28:55 UTC) #2
vivianz
http://codereview.chromium.org/7794011/diff/1/functional/extensions.py File functional/extensions.py (right): http://codereview.chromium.org/7794011/diff/1/functional/extensions.py#newcode192 functional/extensions.py:192: # TODO: need to make pyauto test accept arguments. ...
9 years, 3 months ago (2011-08-31 21:20:16 UTC) #3
commit-bot: I haz the power
Failed to request the patch to try. Please note that binary filesare still unsupported at ...
9 years, 3 months ago (2011-08-31 21:38:29 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-31 22:16:10 UTC) #5
Failed to request the patch to try. Please note that binary filesare still
unsupported at the moment, this is being worked on.

Thanks for your patience.

HTTP Error 302: Found

Powered by Google App Engine
This is Rietveld 408576698