Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(131)

Side by Side Diff: base/json/json_reader.h

Issue 7794003: base/json: Get rid of an old TODO that doesn't apply anymore. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 // Copyright (c) 2011 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 // 4 //
5 // A JSON parser. Converts strings of JSON into a Value object (see 5 // A JSON parser. Converts strings of JSON into a Value object (see
6 // base/values.h). 6 // base/values.h).
7 // http://www.ietf.org/rfc/rfc4627.txt?number=4627 7 // http://www.ietf.org/rfc/rfc4627.txt?number=4627
8 // 8 //
9 // Known limitations/deviations from the RFC: 9 // Known limitations/deviations from the RFC:
10 // - Only knows how to parse ints within the range of a signed 32 bit int and 10 // - Only knows how to parse ints within the range of a signed 32 bit int and
11 // decimal numbers within a double. 11 // decimal numbers within a double.
12 // - Assumes input is encoded as UTF8. The spec says we should allow UTF-16 12 // - Assumes input is encoded as UTF8. The spec says we should allow UTF-16
13 // (BE or LE) and UTF-32 (BE or LE) as well. 13 // (BE or LE) and UTF-32 (BE or LE) as well.
14 // - We limit nesting to 100 levels to prevent stack overflow (this is allowed 14 // - We limit nesting to 100 levels to prevent stack overflow (this is allowed
15 // by the RFC). 15 // by the RFC).
16 // - A Unicode FAQ ("http://unicode.org/faq/utf_bom.html") writes a data 16 // - A Unicode FAQ ("http://unicode.org/faq/utf_bom.html") writes a data
17 // stream may start with a Unicode Byte-Order-Mark (U+FEFF), i.e. the input 17 // stream may start with a Unicode Byte-Order-Mark (U+FEFF), i.e. the input
18 // UTF-8 string for the JSONReader::JsonToValue() function may start with a 18 // UTF-8 string for the JSONReader::JsonToValue() function may start with a
19 // UTF-8 BOM (0xEF, 0xBB, 0xBF). 19 // UTF-8 BOM (0xEF, 0xBB, 0xBF).
20 // To avoid the function from mis-treating a UTF-8 BOM as an invalid 20 // To avoid the function from mis-treating a UTF-8 BOM as an invalid
21 // character, the function skips a Unicode BOM at the beginning of the 21 // character, the function skips a Unicode BOM at the beginning of the
22 // Unicode string (converted from the input UTF-8 string) before parsing it. 22 // Unicode string (converted from the input UTF-8 string) before parsing it.
23 // 23 //
24 // TODO(tc): Add a parsing option to to relax object keys being wrapped in 24 // TODO(tc): Add a parsing option to to relax object keys being wrapped in
25 // double quotes 25 // double quotes
26 // TODO(tc): Add an option to disable comment stripping 26 // TODO(tc): Add an option to disable comment stripping
27 // TODO(aa): Consider making the constructor public and the static Read() method
28 // only a convenience for the common uses with more complex configuration going
29 // on the instance.
30 27
31 #ifndef BASE_JSON_JSON_READER_H_ 28 #ifndef BASE_JSON_JSON_READER_H_
32 #define BASE_JSON_JSON_READER_H_ 29 #define BASE_JSON_JSON_READER_H_
33 #pragma once 30 #pragma once
34 31
35 #include <string> 32 #include <string>
36 33
37 #include "base/base_export.h" 34 #include "base/base_export.h"
38 #include "base/basictypes.h" 35 #include "base/basictypes.h"
39 36
(...skipping 172 matching lines...) Expand 10 before | Expand all | Expand 10 after
212 JsonParseError error_code_; 209 JsonParseError error_code_;
213 int error_line_; 210 int error_line_;
214 int error_col_; 211 int error_col_;
215 212
216 DISALLOW_COPY_AND_ASSIGN(JSONReader); 213 DISALLOW_COPY_AND_ASSIGN(JSONReader);
217 }; 214 };
218 215
219 } // namespace base 216 } // namespace base
220 217
221 #endif // BASE_JSON_JSON_READER_H_ 218 #endif // BASE_JSON_JSON_READER_H_
OLDNEW
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698