chrome/browser/safe_browsing/client_side_detection_service.cc - Issue 7793012: Change the client-side phishing detection hashing function to

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/safe_browsing/client_side_detection_service.cc

Issue 7793012: Change the client-side phishing detection hashing function to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Address Brian's comments Created 9 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/safe_browsing/client_side_detection_service.cc

diff --git a/chrome/browser/safe_browsing/client_side_detection_service.cc b/chrome/browser/safe_browsing/client_side_detection_service.cc

index 30c5deed7a63ff498b95fbba06ce7952c8286bb6..9e800ce141105b58414402910241fa90f49689b5 100644

--- a/chrome/browser/safe_browsing/client_side_detection_service.cc

+++ b/chrome/browser/safe_browsing/client_side_detection_service.cc

@@ -278,9 +278,8 @@ void ClientSideDetectionService::SanitizeRequestForPingback(

ClientPhishingRequest* sanitized_request) {

DCHECK(full_request.IsInitialized());

sanitized_request->Clear();

- if (full_request.has_suffix_prefix_hash()) {

- sanitized_request->set_suffix_prefix_hash(

- full_request.suffix_prefix_hash());

+ if (full_request.has_hash_prefix()) {

+ sanitized_request->set_hash_prefix(full_request.hash_prefix());

}

sanitized_request->set_client_score(full_request.client_score());

if (full_request.has_is_phishing()) {