Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(199)

Unified Diff: chrome/common/safe_browsing/csd.proto

Issue 7793012: Change the client-side phishing detection hashing function to (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/common/safe_browsing/csd.proto
diff --git a/chrome/common/safe_browsing/csd.proto b/chrome/common/safe_browsing/csd.proto
index b700326f4c285f43de99229a7f4ae6c8fa0d05f8..9f4bcfa3bc2c6146f8f19b56cbcacb2d22eb7565 100644
--- a/chrome/common/safe_browsing/csd.proto
+++ b/chrome/common/safe_browsing/csd.proto
@@ -20,10 +20,10 @@ message ClientPhishingRequest {
// client. This field is ONLY set for UMA-enabled users.
optional string url = 1;
- // A 5-byte SHA-256 hash prefix of the URL, in SafeBrowsing host sufffix/path
- // prefix form with query parameters stripped (i.e. "www.example.com/1/2/").
- // Unlike "url", this is sent for all users.
- optional bytes suffix_prefix_hash = 10;
+ // A 5-byte SHA-256 hash prefix of the URL. Before hashing the URL is
+ // canonicalized, converted to a suffix-prefix expression and broadened
+ // (www prefix is removed and everything past the last '/' is stripped).
Brian Ryner 2011/08/30 00:35:10 Keep the comment about this being sent for all use
noelutz 2011/08/30 00:39:52 Done.
+ optional bytes hash_prefix = 10;
// Score that was computed on the client. Value is between 0.0 and 1.0.
// The larger the value the more likely the url is phishing.

Powered by Google App Engine
This is Rietveld 408576698