Change the client-side phishing detection hashing function to

Change the client-side phishing detection hashing function to
mimic what we're doing on the server.

BUG=
TEST=BrowserFeatureExtractorTest


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98848

[mattm, 2011-08-29 22:45:24]

LGTM

[Brian Ryner, 2011-08-30 00:35:10]

LGTM

http://codereview.chromium.org/7793012/diff/1/chrome/browser/safe_browsing/br...
File chrome/browser/safe_browsing/browser_feature_extractor.cc (right):

http://codereview.chromium.org/7793012/diff/1/chrome/browser/safe_browsing/br...
chrome/browser/safe_browsing/browser_feature_extractor.cc:458: // Lowercase the
URL.  Note: canoncalization converts the URL to ASCII.
canoncalization -> canonicalization

http://codereview.chromium.org/7793012/diff/1/chrome/browser/safe_browsing/br...
chrome/browser/safe_browsing/browser_feature_extractor.cc:468: // Checks if the
pattern's path is open: not ending with '/'.
I think this comment came from some server-side logic, but it's kind of
confusing here - I'd consider an 'open' pattern one that _does_ end with '/'. 
Can you clarify it a bit?

http://codereview.chromium.org/7793012/diff/1/chrome/common/safe_browsing/csd...
File chrome/common/safe_browsing/csd.proto (right):

http://codereview.chromium.org/7793012/diff/1/chrome/common/safe_browsing/csd...
chrome/common/safe_browsing/csd.proto:25: // (www prefix is removed and
everything past the last '/' is stripped).
Keep the comment about this being sent for all users?

[noelutz, 2011-08-30 00:39:52]

Thanks for the quick review!
noe.

http://codereview.chromium.org/7793012/diff/1/chrome/browser/safe_browsing/br...
File chrome/browser/safe_browsing/browser_feature_extractor.cc (right):

http://codereview.chromium.org/7793012/diff/1/chrome/browser/safe_browsing/br...
chrome/browser/safe_browsing/browser_feature_extractor.cc:458: // Lowercase the
URL.  Note: canoncalization converts the URL to ASCII.
On 2011/08/30 00:35:10, Brian Ryner wrote:
> canoncalization -> canonicalization

Done.

http://codereview.chromium.org/7793012/diff/1/chrome/browser/safe_browsing/br...
chrome/browser/safe_browsing/browser_feature_extractor.cc:468: // Checks if the
pattern's path is open: not ending with '/'.
On 2011/08/30 00:35:10, Brian Ryner wrote:
> I think this comment came from some server-side logic, but it's kind of
> confusing here - I'd consider an 'open' pattern one that _does_ end with '/'. 
> Can you clarify it a bit?

Done.

http://codereview.chromium.org/7793012/diff/1/chrome/common/safe_browsing/csd...
File chrome/common/safe_browsing/csd.proto (right):

http://codereview.chromium.org/7793012/diff/1/chrome/common/safe_browsing/csd...
chrome/common/safe_browsing/csd.proto:25: // (www prefix is removed and
everything past the last '/' is stripped).
On 2011/08/30 00:35:10, Brian Ryner wrote:
> Keep the comment about this being sent for all users?

Done.

[commit-bot: I haz the power, 2011-08-30 18:23:39]

Change committed as 98848