Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(694)

Issue 7792102: Revert 99391 (broke CrOS unit_tests) - Set user-visible machine names and devices types for synce... (Closed)

Created:
9 years, 3 months ago by Nico
Modified:
9 years, 3 months ago
Reviewers:
Nico
CC:
chromium-reviews, Raghu Simha, ncarter (slow), idana, tim (not reviewing), Paweł Hajdan Jr.
Visibility:
Public.

Description

Revert 99391 (broke CrOS unit_tests) - Set user-visible machine names and devices types for synced sessions. On OSX: - Read the computer name, falling back to reading hw.model and stripping any trialing numbers. This will give us something like MacBookPro, iMac, MacBookAir. On Linux: - Use distro name which gives something like "Ubuntu 10.04.2 LTS". On Windows: - Use the computer name On ChromeOS: - Use "Chromebook" BUG=94693, 59672 TEST=enable session sync, sync two clients, and then look at the entries in about:sync and see that the "client_name" is set Review URL: http://codereview.chromium.org/7740055 Patch from Yaar Friedman <yfriedman@chromium.org>;. TBR=thakis@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99394

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+52 lines, -342 lines) Patch
M chrome/browser/sessions/session_types.h View 1 chunk +11 lines, -0 lines 0 comments Download
M chrome/browser/sessions/session_types.cc View 1 chunk +10 lines, -0 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.h View 8 chunks +1 line, -36 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator.cc View 10 chunks +8 lines, -128 lines 0 comments Download
D chrome/browser/sync/glue/session_model_associator_mac.mm View 1 chunk +0 lines, -52 lines 0 comments Download
M chrome/browser/sync/glue/session_model_associator_unittest.cc View 3 chunks +1 line, -31 lines 0 comments Download
D chrome/browser/sync/glue/synced_session.h View 1 chunk +0 lines, -42 lines 0 comments Download
D chrome/browser/sync/glue/synced_session.cc View 1 chunk +0 lines, -19 lines 0 comments Download
M chrome/browser/sync/glue/synced_session_tracker.h View 1 chunk +0 lines, -1 line 0 comments Download
M chrome/browser/sync/profile_sync_service_session_unittest.cc View 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/sessions_ui.cc View 6 chunks +12 lines, -16 lines 0 comments Download
M chrome/chrome_browser.gypi View 1 chunk +0 lines, -3 lines 0 comments Download
M chrome/test/live_sync/performance/sessions_sync_perf_test.cc View 1 chunk +1 line, -1 line 0 comments Download
M chrome/test/live_sync/sessions_helper.h View 3 chunks +3 lines, -5 lines 0 comments Download
M chrome/test/live_sync/sessions_helper.cc View 4 chunks +5 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
Nico
9 years, 3 months ago (2011-09-02 17:21:45 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698