Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(127)

Issue 7792098: Avoid dynamic lookup when initializing let declared variables. (Closed)

Created:
9 years, 3 months ago by Steven
Modified:
9 years, 3 months ago
Reviewers:
fschneider
CC:
v8-dev
Visibility:
Public.

Description

Avoid dynamic lookup when initializing let declared variables. 'Let's inside a 'with' would initialize the variable using the StoreContextSlot runtime function which would fail because it checks that the variable does not hold the hole value. Committed: http://code.google.com/p/v8/source/detail?r=9156

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -5 lines) Patch
M src/arm/full-codegen-arm.cc View 2 chunks +15 lines, -0 lines 0 comments Download
M src/ia32/full-codegen-ia32.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M src/parser.cc View 1 chunk +8 lines, -5 lines 0 comments Download
M src/x64/full-codegen-x64.cc View 2 chunks +13 lines, -0 lines 0 comments Download
M test/mjsunit/harmony/debug-blockscopes.js View 1 chunk +22 lines, -0 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
Steven
PTAL.
9 years, 3 months ago (2011-09-02 14:05:15 UTC) #1
fschneider
9 years, 3 months ago (2011-09-05 11:41:05 UTC) #2
LGTM.

Powered by Google App Engine
This is Rietveld 408576698