Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3170)

Unified Diff: chrome/browser/sync/profile_sync_service.h

Issue 7792093: Moved the handling of the initial passphrase into SyncSetupFlow. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Painful merge after phajdan's last-minute huge bulk file move. Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/sync/profile_sync_service.h
diff --git a/chrome/browser/sync/profile_sync_service.h b/chrome/browser/sync/profile_sync_service.h
index 5e1b7666ae0bcc8f9603e847e12b84e44197a26b..00f7107529d366bccd40766327dfd29906a83179 100644
--- a/chrome/browser/sync/profile_sync_service.h
+++ b/chrome/browser/sync/profile_sync_service.h
@@ -439,14 +439,10 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
// is known.
// |is_explicit| is true if the call is in response to the user explicitly
// setting a passphrase as opposed to implicitly (from the users' perspective)
- // using their Google Account password. An implicit SetPassphrase will *not*
+ // using their Google Account password. An implicit SetPassphrase will
// *not* override an explicit passphrase set previously.
- // |is_creation| is true if the call is in response to the user setting
- // up a new passphrase, and false if it's being set in response to a prompt
- // for an existing passphrase.
virtual void SetPassphrase(const std::string& passphrase,
- bool is_explicit,
- bool is_creation);
+ bool is_explicit);
// Sets the set of datatypes that are waiting for encryption
// (pending_types_for_encryption_).
@@ -634,16 +630,11 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
// yet have a backend to send it to. This happens during initialization as
// we don't StartUp until we have a valid token, which happens after valid
// credentials were provided.
- struct CachedPassphrase {
- std::string value;
- bool is_explicit;
- bool is_creation;
- CachedPassphrase() : is_explicit(false), is_creation(false) {}
+ struct CachedPassphrases {
+ std::string explicit_passphrase;
+ std::string gaia_passphrase;
};
- CachedPassphrase cached_passphrase_;
-
- // TODO(lipalani): Bug 82221 unify this with the CachedPassphrase struct.
- std::string gaia_password_;
+ CachedPassphrases cached_passphrases_;
// Keep track of where we are in a server clear operation
ClearServerDataState clear_server_data_state_;
@@ -661,6 +652,12 @@ class ProfileSyncService : public browser_sync::SyncFrontend,
syncable::ModelTypeSet pending_types_for_encryption_;
bool set_backend_encrypted_types_;
+ // If true, we want to automatically start sync signin whenever we have
+ // credentials (user doesn't need to go through the startup flow). This is
+ // typically enabled on platforms (like ChromeOS) that have their own
+ // distinct signin flow.
+ bool auto_start_enabled_;
+
scoped_ptr<browser_sync::BackendMigrator> migrator_;
DISALLOW_COPY_AND_ASSIGN(ProfileSyncService);
« no previous file with comments | « no previous file | chrome/browser/sync/profile_sync_service.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698