Print Preview: Handling pending print to pdf requests.

chrome/browser/resources/print_preview/print_preview_animations.js

Index: chrome/browser/resources/print_preview/print_preview_animations.js
diff --git a/chrome/browser/resources/print_preview/print_preview_animations.js b/chrome/browser/resources/print_preview/print_preview_animations.js
index 7d8743315ee1fc7456094606eb12c8d850f94667..7f3c8b035866cebae56f4ce85674ed26597881ed 100644
--- a/chrome/browser/resources/print_preview/print_preview_animations.js
+++ b/chrome/browser/resources/print_preview/print_preview_animations.js
@@ -78,15 +78,33 @@ function fadeInOutCleanup(animationName) {
     animEl.parentNode.removeChild(animEl);
 }
 
-function showLoadingAnimation() {
-  $('dancing-dots-text').classList.remove('hidden');
+/**
+ * Displays |message| followed by three dancing dots animation.
+ */
+function showCustomMessage(message) {
+  $('custom-message-with-dots').innerHTML = message +
+      $('dancing-dots-text').innerHTML;

[arv (Not doing code reviews), 2011/09/07 21:53:52]

No, don't use innerHTML like this. There is no point serializing
#dancing-dots-text to HTML here. Do something like:

var customMessageWithDots = $('custom-message-with-dots');
var textNode = document.createTextNode(message);
customMessageWithDots.insertBefore(textNode, customMessageWithDots.firstChild);

[dpapad, 2011/09/08 03:29:20]

This results in a larger spacing between the dancing dots and the displayed
message, so I would prefer to keep this as is. There was a similar bug a long
time ago about this (#82965).

+  $('custom-message-with-dots').classList.remove('hidden');

[arv (Not doing code reviews), 2011/09/07 21:53:52]

hidden = false

[dpapad, 2011/09/08 03:29:20]

Done.

   var pdfViewer = $('pdf-viewer');
   if (pdfViewer)
     pdfViewer.classList.add('invisible');
   $('overlay-layer').classList.remove('invisible');
 }
 
-function hideLoadingAnimation() {
+/**
+ * Displays the "Preview loading..." animation.
+ */
+function showLoadingAnimation() {
+  showCustomMessage(localStrings.getString('loading'));
+}
+
+/**
+ * Hides the |overlay-layer| and any messages curretnly displayed.
+ */
+function hideOverlayLayer() {
+  if (hasPendingPrintToPdfRequest)

[vandebo (ex-Chrome), 2011/09/07 21:38:19]

It's not clear to me if this is needed.  As soon as we have the PDF we're going
to close the tab.

[dpapad, 2011/09/07 23:42:39]

This is addressing a corner case, when the user has requested to print to pdf
while metafile is not ready (and therefore the message is shown), and then the
first page comes back. Normally this would hide the overlay layer and display
the first page, but in this case we want to keep displaying "Printing to PDF in
progress". Note that this function is called way before we have the PDF metafile
ready.

+    return;
+
   var overlayLayer = $('overlay-layer');
   overlayLayer.addEventListener('webkitTransitionEnd', loadingAnimationCleanup);
   var pdfViewer = $('pdf-viewer');
@@ -96,7 +114,7 @@ function hideLoadingAnimation() {
 }
 
 function loadingAnimationCleanup() {
-  $('dancing-dots-text').classList.add('hidden');
+  $('custom-message-with-dots').classList.add('hidden');
   $('overlay-layer').removeEventListener('webkitTransitionEnd',
                                          loadingAnimationCleanup);
 }