Print Preview: Handling pending print to pdf requests.

chrome/browser/ui/webui/print_preview_handler.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/webui/print_preview_handler.h"
 
 #include <string>
 
 #include "base/base64.h"
 #if !defined(OS_CHROMEOS)
@@ skipping 565 matching lines @@
   settings->SetBoolean(printing::kSettingHeaderFooterEnabled, false);
 
   TabContentsWrapper* preview_tab_wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(preview_tab());
 
   bool print_to_cloud = settings->HasKey(printing::kSettingCloudPrintId);
   if (print_to_cloud) {
     std::string print_ticket;
     args->GetString(1, &print_ticket);
     SendCloudPrintJob(*settings, print_ticket);
   } else if (print_to_pdf) {

[dpapad, 2011/09/02 18:36:33]

I would prefer to move this big else if block to a method named
HandlePrintToPdf(), is that ok?

[kmadhusu, 2011/09/02 21:47:03]

sounds good to me.

[dpapad, 2011/09/07 00:46:19]

Done.

     ReportUserActionHistogram(PRINT_TO_PDF);
     UMA_HISTOGRAM_COUNTS("PrintPreview.PageCount.PrintToPDF",
                          GetPageCountFromSettingsDictionary(*settings));
 
-    // Pre-populating select file dialog with print job title.
-    string16 print_job_title_utf16 =
-        preview_tab_wrapper->print_view_manager()->RenderSourceName();
+    if (!pending_print_to_pdf_path_.empty()) {
+      // User has already selected a path, no need to show the dialog again.
+      FilePath& temp_path = pending_print_to_pdf_path_;

[kmadhusu, 2011/09/02 21:47:03]

Is this temp_path necessary?

[dpapad, 2011/09/07 00:46:19]

Done. Changed pending_print_to_pdf_path_ to be a scoped_ptr.

+      PostPrintToPdfTask(temp_path, true);
+    } else if (!select_file_dialog_.get() || !select_file_dialog_->IsRunning(
+          platform_util::GetTopLevel(preview_tab()->GetNativeView()))) {
+      // Pre-populating select file dialog with print job title.
+      string16 print_job_title_utf16 =
+          preview_tab_wrapper->print_view_manager()->RenderSourceName();
 
 #if defined(OS_WIN)
-    FilePath::StringType print_job_title(print_job_title_utf16);
+      FilePath::StringType print_job_title(print_job_title_utf16);
 #elif defined(OS_POSIX)
-    FilePath::StringType print_job_title = UTF16ToUTF8(print_job_title_utf16);
+      FilePath::StringType print_job_title = UTF16ToUTF8(print_job_title_utf16);
 #endif
 
-    file_util::ReplaceIllegalCharactersInPath(&print_job_title, '_');
-    FilePath default_filename(print_job_title);
-    default_filename =
-        default_filename.ReplaceExtension(FILE_PATH_LITERAL("pdf"));
+      file_util::ReplaceIllegalCharactersInPath(&print_job_title, '_');
+      FilePath default_filename(print_job_title);
+      default_filename =
+          default_filename.ReplaceExtension(FILE_PATH_LITERAL("pdf"));
 
-    SelectFile(default_filename);
+      SelectFile(default_filename);
+    }
   } else {
     ReportPrintSettingsStats(*settings);
     ReportUserActionHistogram(PRINT_TO_PRINTER);
     UMA_HISTOGRAM_COUNTS("PrintPreview.PageCount.PrintToPrinter",
                          GetPageCountFromSettingsDictionary(*settings));
 
     // This tries to activate the initiator tab as well, so do not clear the
     // association with the initiator tab yet.
     HidePreviewTab();
 
@@ skipping 305 matching lines @@
   reported_failed_preview_ = true;
   ReportUserActionHistogram(PREVIEW_FAILED);
 }
 
 void PrintPreviewHandler::ShowSystemDialog() {
   HandleShowSystemDialog(NULL);
 }
 
 void PrintPreviewHandler::FileSelected(const FilePath& path,
                                        int index, void* params) {
+  // Updating last_saved_path_ to the newly selected folder.
+  *last_saved_path_ = path.DirName();
+
+  PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(web_ui_);
+  print_preview_ui->OnFileSelectionCompleted();
+  scoped_refptr<RefCountedBytes> data;
+  print_preview_ui->GetPrintPreviewDataForIndex(
+      printing::COMPLETE_PREVIEW_DOCUMENT_INDEX, &data);
+  if (!data.get()) {
+    pending_print_to_pdf_path_ = path;
+  } else {
+    FilePath temp_path(path);
+    PostPrintToPdfTask(temp_path, false);
+  }
+}
+
+void PrintPreviewHandler::PostPrintToPdfTask(FilePath& path, bool is_pending) {
   PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(web_ui_);
   scoped_refptr<RefCountedBytes> data;
   print_preview_ui->GetPrintPreviewDataForIndex(
       printing::COMPLETE_PREVIEW_DOCUMENT_INDEX, &data);
-  if (!data.get()) {
-    NOTREACHED();
-    return;
-  }
-
   printing::PreviewMetafile* metafile = new printing::PreviewMetafile;
   metafile->InitFromData(static_cast<const void*>(data->front()), data->size());
-
-  // Updating last_saved_path_ to the newly selected folder.
-  *last_saved_path_ = path.DirName();
-
   PrintToPdfTask* task = new PrintToPdfTask(metafile, path);
   BrowserThread::PostTask(BrowserThread::FILE, FROM_HERE, task);
-
-  ActivateInitiatorTabAndClosePreviewTab();
+  pending_print_to_pdf_path_.clear();
+  is_pending ? delete preview_tab_wrapper() :

[kmadhusu, 2011/09/02 21:47:03]

I prefer to have Y ? A : B  in an assignment statement(X = Y ? A : B;) but not
as a independent statement.

Can you make this as if (Y) then A else B?

[dpapad, 2011/09/07 00:46:19]

No need anymore, I am not hiding the preview tab, so I can always call
ActivateInitiatorTabAndClosePreviewTab(). Also, I removed the is_pending
parameter.

+      ActivateInitiatorTabAndClosePreviewTab();
 }
 
 void PrintPreviewHandler::FileSelectionCanceled(void* params) {
   PrintPreviewUI* print_preview_ui = static_cast<PrintPreviewUI*>(web_ui_);
   print_preview_ui->OnFileSelectionCancelled();
 }
 
 void PrintPreviewHandler::HidePreviewTab() {
   TabContentsWrapper* preview_tab_wrapper =
       TabContentsWrapper::GetCurrentWrapperForContents(preview_tab());
   if (GetBackgroundPrintingManager()->HasPrintPreviewTab(preview_tab_wrapper))
     return;
   GetBackgroundPrintingManager()->OwnPrintPreviewTab(preview_tab_wrapper);
 }
 
 void PrintPreviewHandler::ClearInitiatorTabDetails() {
   TabContentsWrapper* initiator_tab = GetInitiatorTab();
   if (!initiator_tab)
     return;
 
   // We no longer require the initiator tab details. Remove those details
   // associated with the preview tab to allow the initiator tab to create
   // another preview tab.
   printing::PrintPreviewTabController* tab_controller =
      printing::PrintPreviewTabController::GetInstance();
   if (tab_controller)
     tab_controller->EraseInitiatorTabInfo(preview_tab_wrapper());
 }