Print Preview: Handling pending print to pdf requests.

chrome/browser/resources/print_preview/print_preview.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: cr/ui/print_preview_cloud.js
 
 var localStrings = new LocalStrings();
 
 // If useCloudPrint is true we attempt to connect to cloud print
 // and populate the list of printers with cloud print printers.
@@ skipping 415 matching lines @@
  * Asks the browser to print the preview PDF based on current print
  * settings. If the preview is still loading, printPendingFile() will get
  * called once the preview loads.
  */
 function requestToPrintDocument() {
   hasPendingPrintDocumentRequest = !isPrintReadyMetafileReady;
   var printToPDF = getSelectedPrinterName() == PRINT_TO_PDF;
 
   if (hasPendingPrintDocumentRequest) {
     if (printToPDF) {
-      // TODO(thestig) disable controls here.
-     } else {
-       isTabHidden = true;
-       chrome.send('hidePreview');
-     }
+      sendPrintDocumentRequest();
+    } else {
+      isTabHidden = true;
+      chrome.send('hidePreview');

[kmadhusu, 2011/09/02 21:47:03]

Create a helper function to set isTabHidden = true and to send "hidePreview"
message.

[dpapad, 2011/09/07 00:46:19]

This is only performed once here (as of latest patch), so I think it is not
necessary to create a helper function.

+    }
     return;
   }
 
   if (printToPDF) {
     sendPrintDocumentRequest();
   } else {
     window.setTimeout(function() { sendPrintDocumentRequest(); }, 1000);
   }
 }
 
@@ skipping 78 matching lines @@
 }
 
 /**
  * Called from PrintPreviewUI::OnFileSelectionCancelled to notify the print
  * preview tab regarding the file selection cancel event.
  */
 function fileSelectionCancelled() {
   // TODO(thestig) re-enable controls here.
 }
 
+function fileSelectionCompleted() {
+  isTabHidden = true;

[kmadhusu, 2011/09/02 21:47:03]

Call that helper function here.

[dpapad, 2011/09/07 00:46:19]

The preview tab is not hidden anymore here, instead a message is displayed.

+  chrome.send('hidePreview');
+}
+
 /**
  * Set the default printer. If there is one, generate a print preview.
  * @param {string} printer Name of the default printer. Empty if none.
  * @param {string} cloudPrintData Cloud print related data to restore if
  *                 the default printer is a cloud printer.
  */
 function setDefaultPrinter(printer_name, cloudPrintData) {
   // Add a placeholder value so the printer list looks valid.
   addDestinationListOption('', '', true, true, true);
   if (printer_name) {
@@ skipping 422 matching lines @@
 /**
  * Update the print preview when new preview data is available.
  * Create the PDF plugin as needed.
  * Called from PrintPreviewUI::PreviewDataIsAvailable().
  * @param {boolean} modifiable If the preview is modifiable.
  * @param {string} previewUid Preview unique identifier.
  * @param {number} previewResponseId The preview request id that resulted in
  *     this response.
  */
 function updatePrintPreview(previewUid, previewResponseId) {
+  console.log("updatePrintPreview " + previewResponseId);

[kmadhusu, 2011/09/02 21:47:03]

remove console.log

[dpapad, 2011/09/07 00:46:19]

Done.

   if (!isExpectedPreviewResponse(previewResponseId))
     return;
   hasPendingPreviewRequest = false;
   isPrintReadyMetafileReady = true;
 
   if (!previewModifiable) {
     // If the preview is not modifiable the plugin has not been created yet.
     currentPreviewUid = previewUid;
     createPDFPlugin(PRINT_READY_DATA_INDEX);
   }
@@ skipping 98 matching lines @@
 <include src="print_preview_animations.js"/>
 <include src="print_preview_cloud.js"/>
 <include src="print_preview_utils.js"/>
 <include src="print_header.js"/>
 <include src="page_settings.js"/>
 <include src="copies_settings.js"/>
 <include src="header_footer_settings.js"/>
 <include src="layout_settings.js"/>
 <include src="color_settings.js"/>
 <include src="margin_settings.js"/>