Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(985)

Issue 7792062: Disable failed test GetTerminationStatusExit on Linux. (Closed)

Created:
9 years, 3 months ago by dyu1
Modified:
9 years, 3 months ago
Reviewers:
brettw, M-A Ruel
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Disable failed test GetTerminationStatusExit on Linux. BUG=95058 TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99207

Patch Set 1 #

Total comments: 1

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+8 lines, -1 line) Patch
base/process_util_unittest.cc View 1 1 chunk +8 lines, -1 line 0 comments Download

Messages

Total messages: 8 (0 generated)
dyu1
9 years, 3 months ago (2011-09-01 16:34:58 UTC) #1
M-A Ruel
lgtm with fix. http://codereview.chromium.org/7792062/diff/1/base/process_util_unittest.cc File base/process_util_unittest.cc (right): http://codereview.chromium.org/7792062/diff/1/base/process_util_unittest.cc#newcode140 base/process_util_unittest.cc:140: #if defined(OS LINUX) #if defined(OS_LINUX) !
9 years, 3 months ago (2011-09-01 17:12:05 UTC) #2
commit-bot: I haz the power
Can't process patch for file base/process_util_unittest.cc. File's status is None, patchset upload is incomplete.
9 years, 3 months ago (2011-09-01 17:17:04 UTC) #3
dyu1
9 years, 3 months ago (2011-09-01 17:22:24 UTC) #4
M-A Ruel
That's weird as there is indeed no status. Just commit.
9 years, 3 months ago (2011-09-01 17:34:34 UTC) #5
dyu1
On 2011/09/01 17:34:34, Marc-Antoine Ruel wrote: > That's weird as there is indeed no status. ...
9 years, 3 months ago (2011-09-01 17:37:34 UTC) #6
M-A Ruel
On 2011/09/01 17:37:34, dyu1 wrote: > I tried. I need a LGTM from someone in ...
9 years, 3 months ago (2011-09-01 17:39:32 UTC) #7
brettw
9 years, 3 months ago (2011-09-01 17:44:32 UTC) #8
LGTM

Powered by Google App Engine
This is Rietveld 408576698