Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1067)

Unified Diff: src/v8natives.js

Issue 7792054: Make arguments and caller always be null on native functions (fixes issue 1548 and issue 1643). (Closed) Base URL: http://v8.googlecode.com/svn/branches/bleeding_edge/
Patch Set: Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/v8natives.js
===================================================================
--- src/v8natives.js (revision 9034)
+++ src/v8natives.js (working copy)
@@ -55,6 +55,13 @@
var f = functions[i + 1];
%FunctionSetName(f, key);
%FunctionRemovePrototype(f);
+ %IgnoreAttributesAndSetProperty(f, "caller",
Lasse Reichstein 2011/09/01 08:23:49 Add comment that we don't match Safari, but we do
+ null,
+ DONT_ENUM | DONT_DELETE);
+ %IgnoreAttributesAndSetProperty(f, "arguments",
+ null,
+ DONT_ENUM | DONT_DELETE);
+
Lasse Reichstein 2011/09/01 08:23:49 Add a test that this works? E.g., [1].map(functio
%SetProperty(object, key, f, attributes);
%SetNativeFlag(f);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698