Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(664)

Issue 7792054: Make arguments and caller always be null on native functions (fixes issue 1548 and issue 1643). (Closed)

Created:
9 years, 3 months ago by Rico
Modified:
9 years, 3 months ago
CC:
v8-dev
Visibility:
Public.

Description

Make arguments and caller always be null on native functions (fixes issue 1548 and issue 1643). With this change we follow Firefox, Safari has a slightly different approach where the property is just not there (at least according to GetOwnProperty). Committed: http://code.google.com/p/v8/source/detail?r=9093

Patch Set 1 #

Total comments: 2

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+47 lines, -0 lines) Patch
M src/v8natives.js View 1 2 3 4 1 chunk +9 lines, -0 lines 0 comments Download
A test/mjsunit/regress/regress-1548.js View 1 1 chunk +38 lines, -0 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Rico
Kevin: removing the arguments property should not be a problem right?
9 years, 3 months ago (2011-09-01 08:15:51 UTC) #1
Lasse Reichstein
LGTM. We create the arguments object dynamically in the accessor, so not calling the accessor ...
9 years, 3 months ago (2011-09-01 08:23:49 UTC) #2
Rico
Comment addressed and left out regression test file added
9 years, 3 months ago (2011-09-01 08:35:11 UTC) #3
Kevin Millikin (Chromium)
9 years, 3 months ago (2011-09-01 09:19:08 UTC) #4
LGTM.  The test should probably be repeated for .arguments for completeness.

Powered by Google App Engine
This is Rietveld 408576698