Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(89)

Issue 7792046: Merge 96076 - Use MessageLoopProxy instead of MessageLoop to dispatch notifications in ObserverLi... (Closed)

Created:
9 years, 3 months ago by adamk
Modified:
9 years, 3 months ago
Reviewers:
adamk
CC:
chromium-reviews, brettw-cc_chromium.org, Paweł Hajdan Jr.
Visibility:
Public.

Description

Merge 96076 - Use MessageLoopProxy instead of MessageLoop to dispatch notifications in ObserverListThreadsafe. This is nearly identical to the reverted r96013, with the modification that std::map::insert isn't used. Its invocation was complex (such that it worked in some compilers but not in others) and the performance gain is negligible in any use case I've seen in Chromium. BUG=91589 Review URL: http://codereview.chromium.org/7604006 TBR=adamk@chromium.org Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98841

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+71 lines, -23 lines) Patch
M base/observer_list_threadsafe.h View 10 chunks +30 lines, -17 lines 0 comments Download
M base/observer_list_unittest.cc View 4 chunks +41 lines, -6 lines 0 comments Download

Messages

Total messages: 1 (0 generated)
adamk
9 years, 3 months ago (2011-08-30 18:06:30 UTC) #1

          

Powered by Google App Engine
This is Rietveld 408576698