Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(157)

Issue 7792041: roll skia to 2193 (Closed)

Created:
9 years, 3 months ago by reed1
Modified:
9 years, 3 months ago
CC:
chromium-reviews
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Total comments: 2

Patch Set 4 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -27 lines) Patch
M DEPS View 1 2 3 1 chunk +1 line, -1 line 0 comments Download
M webkit/glue/media/video_renderer_impl.cc View 1 2 3 2 chunks +1 line, -26 lines 0 comments Download

Messages

Total messages: 6 (0 generated)
reed1
9 years, 3 months ago (2011-08-30 17:12:18 UTC) #1
reed1
adding owner for webkit/glue/media
9 years, 3 months ago (2011-08-30 17:13:13 UTC) #2
reed1
Removed check against device bounds, since by definition the global clip must be contained within ...
9 years, 3 months ago (2011-08-30 17:14:43 UTC) #3
scherkus (not reviewing)
LGTM w/ nit http://codereview.chromium.org/7792041/diff/3/webkit/glue/media/video_renderer_impl.cc File webkit/glue/media/video_renderer_impl.cc (right): http://codereview.chromium.org/7792041/diff/3/webkit/glue/media/video_renderer_impl.cc#newcode118 webkit/glue/media/video_renderer_impl.cc:118: // Get the properties of the ...
9 years, 3 months ago (2011-08-30 17:21:38 UTC) #4
epoger
On 2011/08/30 17:21:38, scherkus wrote: > LGTM w/ nit > > http://codereview.chromium.org/7792041/diff/3/webkit/glue/media/video_renderer_impl.cc > File webkit/glue/media/video_renderer_impl.cc ...
9 years, 3 months ago (2011-08-30 17:34:45 UTC) #5
reed1
9 years, 3 months ago (2011-08-30 17:42:16 UTC) #6
linux_layout failure unrelated to this CL

http://codereview.chromium.org/7792041/diff/3/webkit/glue/media/video_rendere...
File webkit/glue/media/video_renderer_impl.cc (right):

http://codereview.chromium.org/7792041/diff/3/webkit/glue/media/video_rendere...
webkit/glue/media/video_renderer_impl.cc:118: // Get the properties of the
SkDevice
On 2011/08/30 17:21:38, scherkus wrote:
> I was going to nit about adding a period, but this comment and the one below
are
> utterly useless -- mind removing them while you're in here?

Done.

Powered by Google App Engine
This is Rietveld 408576698