[cros] User image selection with keyboard arrows works.

chrome/browser/resources/chromeos/login/oobe_screen_user_image.js

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 /**
  * @fileoverview Oobe user image screen implementation.
  */
 
 cr.define('oobe', function() {
   /**
@@ skipping 107 matching lines @@
       UserImageScreen.addUserImage(
           imageUrl,
           UserImageScreen.handleImageClick);
     }
 
     var userImageScreen = $('user-image');
     var userImageList = $('user-image-list');
     userImageList.addEventListener('keydown', function(e) {
       var prevIndex = userImageScreen.selectedUserImage_;
       var len = userImageList.children.length;
+      var nextIndex;
       if (e.keyCode == 39 || e.keyCode == 40)  // right or down
-        UserImageScreen.selectUserImage((prevIndex + 1) % len);
+        nextIndex = (prevIndex + 1) % len;
       else if (e.keyCode == 37 || e.keyCode == 38)  // left or up
-        UserImageScreen.selectUserImage((prevIndex - 1 + len) % len);
+        nextIndex = (prevIndex - 1 + len) % len;
+      else if (e.keyCode == 13 && prevIndex == 0)
+        // Enter pressed while "Take photo" button active.
+        chrome.send('takePhoto');
+      if (nextIndex == 0)
+        // "Take photo" button: don't send a selection event to Chrome,
+        // just focus element and update selected index.
+        UserImageScreen.selectUserImage(0);
+      else if (nextIndex) {

[whywhat, 2011/08/30 12:03:14]

nit: be consistent when using {}: I'd use it in both if/else statements in this
function (since some branches occupy more than one line with comments).

[Ivan Korotkov, 2011/08/30 12:16:40]

Done.

+        chrome.send('selectImage', [userImageList.children[nextIndex].src]);
+      }
       e.stopPropagation();
     });
   };
 
   /**
    * Selects the specified user image and shows it in preview.
    * @param {number} index The index of the image to select.
    */
   UserImageScreen.selectUserImage = function(index) {
     var userImageList = $('user-image-list');
@@ skipping 10 matching lines @@
       selectedImage.focus();
       $('user-image-preview').src = selectedImage.src;
     }
     userImageScreen.selectedUserImage_ = index;
   };
 
   return {
     UserImageScreen: UserImageScreen
   };
 });