[cros] User image selection with keyboard arrows works.

[cros] User image selection with keyboard arrows works.

BUG=chromium-os:18993
TEST=Manual: login with WebUI, choose user image using keyboard arrows. Settings->Personal Stuff should display the chosen image.


Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98829

[whywhat, 2011-08-30 12:03:14]

LGTM

http://codereview.chromium.org/7792036/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right):

http://codereview.chromium.org/7792036/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:140: else if
(nextIndex) {
nit: be consistent when using {}: I'd use it in both if/else statements in this
function (since some branches occupy more than one line with comments).

[Ivan Korotkov, 2011-08-30 12:16:39]

http://codereview.chromium.org/7792036/diff/1/chrome/browser/resources/chrome...
File chrome/browser/resources/chromeos/login/oobe_screen_user_image.js (right):

http://codereview.chromium.org/7792036/diff/1/chrome/browser/resources/chrome...
chrome/browser/resources/chromeos/login/oobe_screen_user_image.js:140: else if
(nextIndex) {
On 2011/08/30 12:03:14, whywhat wrote:
> nit: be consistent when using {}: I'd use it in both if/else statements in
this
> function (since some branches occupy more than one line with comments).

Done.

[commit-bot: I haz the power, 2011-08-30 15:30:46]

Try job failure for 7792036-3001 (retry) on win for step "update".
It's a second try, previously, step "ui_tests" failed.
http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win&number...

Step "update" is always a major failure.
Look at the try server FAQ for more details.

[commit-bot: I haz the power, 2011-08-30 16:56:06]

Change committed as 98829