Issue 7792032: Merge 94045 - REGRESSION(r88115): Disabling a file upload control causes an endless busyloop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7792032: Merge 94045 - REGRESSION(r88115): Disabling a file upload control causes an endless busyloop. (Closed)

Created:
9 years, 3 months ago by tkent

Modified:
9 years, 3 months ago

Reviewers:
tkent

CC:
chromium-reviews

Base URL:
http://svn.webkit.org/repository/webkit/branches/chromium/835/

Visibility:
Public.

Description

Merge 94045 - REGRESSION(r88115): Disabling a file upload control causes an endless busyloop. https://bugs.webkit.org/show_bug.cgi?id=66659 Reviewed by Darin Adler. Source/WebCore: Test: fast/forms/file/disabling-file-busy-loop.html * rendering/RenderFileUploadControl.cpp: (WebCore::RenderFileUploadControl::updateFromElement): Don't call setDisabled() if the disabled status is not changed. setDisabled() causes styleRecalc(), and HTMLFormControlElement::styleRecalc() causes updateFromElement(). updateFromElement() should not call setDisabled() again. LayoutTests: * fast/forms/file/disabling-file-busy-loop-expected.txt: Added. * fast/forms/file/disabling-file-busy-loop.html: Added. TBR=tkent@chromium.org BUG=94710 Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=94059

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+9 lines, -2 lines)			Patch
	M	Source/WebCore/rendering/RenderFileUploadControl.cpp	View		1 chunk	+9 lines, -2 lines	0 comments	Download

Messages

Total messages: 1 (0 generated)

Expand Messages | Collapse Messages