Show app disable and enable on NTP, and desaturate non-offline-enabled apps when offline.

Show app disable and enable on NTP, and desaturate non-offline-enabled apps when offline.

Refactor to put the logic for NTP app grayscaling in Javascript.
Disabled and terminated apps don't disappear from the NTP.
Update the NTP apps when offline status changes.

Caveat: the webstore icon doesn't get desaturated.

BUG=89655, 94322, 90433
TEST=Open NTP with packaged apps in disabled/enabled state; observe them changing
color when disabled/enabled via chrome://extensions page. Observe color changes
when network interface is unplugged.

Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98908

[Yoyo Zhou, 2011-08-30 02:13:27]

This is my revised, more efficient approach -- you can disregard the earlier CL
I sent out last week.

[Evan Stade, 2011-08-30 03:34:14]

cool, just nits

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:370: if (app) {
no curlies

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:383: function appRemoved(appData,
is_uninstall) {
isUninstall

also, doc the param

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:119: // Instead of setting
grayscale here, we do it in the js.
probably best to check for NTP4

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:299: bool is_uninstall =
define this right above first use, not here

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:300:
(Details<UnloadedExtensionInfo>(details)->reason ==
don't need ()

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:316: }
no break?

[Yoyo Zhou, 2011-08-30 17:37:10]

I just was able to sync past your fix to crbug.com/94095 (darn git mirrors), so
please make sure this all still makes sense.

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/resources/ntp...
File chrome/browser/resources/ntp4/new_tab.js (right):

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:370: if (app) {
On 2011/08/30 03:34:14, Evan Stade wrote:
> no curlies

Done.

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/resources/ntp...
chrome/browser/resources/ntp4/new_tab.js:383: function appRemoved(appData,
is_uninstall) {
On 2011/08/30 03:34:14, Evan Stade wrote:
> isUninstall
> 
> also, doc the param

Done.

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
File chrome/browser/ui/webui/ntp/app_launcher_handler.cc (right):

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:119: // Instead of setting
grayscale here, we do it in the js.
On 2011/08/30 03:34:14, Evan Stade wrote:
> probably best to check for NTP4

Done.

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:299: bool is_uninstall =
On 2011/08/30 03:34:14, Evan Stade wrote:
> define this right above first use, not here

Done.

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:300:
(Details<UnloadedExtensionInfo>(details)->reason ==
On 2011/08/30 03:34:14, Evan Stade wrote:
> don't need ()

Gone.

http://codereview.chromium.org/7792024/diff/5001/chrome/browser/ui/webui/ntp/...
chrome/browser/ui/webui/ntp/app_launcher_handler.cc:316: }
On 2011/08/30 03:34:14, Evan Stade wrote:
> no break?

Argh, lost it in the merge. Good catch.

[Evan Stade, 2011-08-30 19:25:58]

lgtm

[Yoyo Zhou, 2011-08-30 20:51:14]

On 2011/08/30 19:25:58, Evan Stade wrote:
> lgtm

FYI, I had to add this line to updateOfflineEnabledApps:
    var apps = document.querySelectorAll('.app');

trybots don't seem to want to start right now.