Issue 7792017: Hack to fix margin issues with client plugin.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7792017: Hack to fix margin issues with client plugin. (Closed)

Created:
9 years, 3 months ago by Jamie

Modified:
9 years, 3 months ago

Reviewers:
garykac

CC:
chromium-reviews, jamiewalch+watch_chromium.org, hclam+watch_chromium.org, simonmorris+watch_chromium.org, wez+watch_chromium.org, dmaclach+watch_chromium.org, garykac+watch_chromium.org, lambroslambrou+watch_chromium.org, ajwong+watch_chromium.org, sergeyu+watch_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Hack to fix margin issues with client plugin. BUG=None TEST=Enable scaling; make sure there are no vertical scroll-bars visible. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98842

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -1 line)			Patch
	M	remoting/webapp/me2mom/choice.css	View		1 chunk	+4 lines, -1 line	0 comments	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Jamie

PTAL. My previous CL to remove the vertical scroll-bar when scaling is enabled doesn't appear ...

9 years, 3 months ago (2011-08-29 22:24:40 UTC) #1

garykac

9 years, 3 months ago (2011-08-30 18:10:18 UTC) #2

On 2011/08/29 22:24:40, Jamie wrote:
> PTAL.
> 
> My previous CL to remove the vertical scroll-bar when scaling is enabled
doesn't
> appear to work, so here's a hackier version that does. I don't understand why
> Chrome is adding an extra 4px inside the host-plugin-container <div>, but it
is
> (check the Metrics tab when the plugin and its <div> container are selected.
> Because it's the margin, we could shave off more than 4px without losing any
> clickable area, but we have to be careful not to shave off more than the total
> height of the <div>, or things don't render correctly.

LGTM. Although I feel the need to say "ick" ^_^

Expand Messages | Collapse Messages