Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(205)

Issue 7792015: An improved fix for TTS Extension API problems on Windows. (Closed)

Created:
9 years, 3 months ago by dmazzoni
Modified:
9 years, 3 months ago
Reviewers:
Ben Olmstead
CC:
chromium-reviews, Aaron Boodman, Erik does not do reviews, mihaip+watch_chromium.org
Visibility:
Public.

Description

An improved fix for TTS Extension API problems on Windows. The Windows speech API doesn't have a Stop function, and we were using Pause before to implement this, but this meant the utterance was still around, causing events from a previous utterance to still get sent when speech was resumed again. Instead, now we call Speak with an empty string and cause it to flush the speech queue. This ensures that only one utterance is active at a time. BUG=94466 TEST=manual testing with several talking extensions Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=99015

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -13 lines) Patch
M chrome/browser/extensions/extension_tts_api_win.cc View 5 chunks +7 lines, -13 lines 0 comments Download

Messages

Total messages: 2 (0 generated)
dmazzoni
9 years, 3 months ago (2011-08-29 21:57:26 UTC) #1
Ben Olmstead
9 years, 3 months ago (2011-08-30 20:55:43 UTC) #2
LGTM

Powered by Google App Engine
This is Rietveld 408576698