Run LocalizeStrings() on plugin thread.

remoting/host/plugin/host_plugin_utils.cc

 // Copyright (c) 2011 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "remoting/host/plugin/host_plugin_utils.h"
 
 namespace remoting {
 
 NPNetscapeFuncs* g_npnetscape_funcs = NULL;
 
@@ skipping 24 matching lines @@
 }
 
 NPObject* ObjectFromNPVariant(const NPVariant& variant) {
   if (!NPVARIANT_IS_OBJECT(variant))
     return NULL;
   return NPVARIANT_TO_OBJECT(variant);
 }
 
 ScopedRefNPObject::ScopedRefNPObject() : object_(NULL) { }
 
+ScopedRefNPObject::ScopedRefNPObject(NPObject* object) : object_(object) {

[Sergey Ulanov, 2011/08/30 00:53:08]

nit: move member initialization to the next line.

[Lambros, 2011/08/30 01:49:26]

Done.

+  if (object) {
+    g_npnetscape_funcs->retainobject(object);
+  }
+}
+

[Jamie, 2011/08/30 00:43:34]

When I write objects where the ctor and operator= semantics are basically the
same, I like to write one using the other, ie:

ScopedRefNPObject(NPObject* object) : object_(NULL) {
  *this = object;
}

It keeps them in sync and is generally less typing.

[Sergey Ulanov, 2011/08/30 00:53:08]

I suppose this will not work because of DISALLOW_COPY_AND_ASSIGN().

[Jamie, 2011/08/30 00:57:55]

It should work because the parameter is an NPObject*, not a const
ScopedRefNPObject&

[Lambros, 2011/08/30 01:49:26]

Done.

 ScopedRefNPObject::~ScopedRefNPObject() {
   *this = NULL;
 }
 
 ScopedRefNPObject& ScopedRefNPObject::operator=(NPObject* object) {
   if (object) {
     g_npnetscape_funcs->retainobject(object);
   }
   if (object_) {
     g_npnetscape_funcs->releaseobject(object_);
   }
   object_ = object;
   return *this;
 }
 
 }  // namespace remoting