Issue 7792009: [ChromeOS] Hide 'signin-right' panel when it's empty.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7792009: [ChromeOS] Hide 'signin-right' panel when it's empty. (Closed)

Created:
9 years, 3 months ago by xiyuan

Modified:
9 years, 3 months ago

Reviewers:
achuithb, commit-bot: I haz the power

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

[ChromeOS] Hide 'signin-right' panel when it's empty. So that we show Gaia horizonally center. BUG=chromium-os:19779 TEST=Verify fix for chromium-os:19779. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98717

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+8 lines, -7 lines)			Patch
	M	chrome/browser/resources/chromeos/login/screen_gaia_signin.js	View		1 chunk	+4 lines, -1 line	1 comment	Download
	M	chrome/browser/resources/chromeos/login/screen_signin.css	View		2 chunks	+4 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

achuithb

LGTM. http://codereview.chromium.org/7792009/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js File chrome/browser/resources/chromeos/login/screen_gaia_signin.js (right): http://codereview.chromium.org/7792009/diff/1/chrome/browser/resources/chromeos/login/screen_gaia_signin.js#newcode64 chrome/browser/resources/chromeos/login/screen_gaia_signin.js:64: ($('createAccount').hidden && $('guestSignin').hidden); Tricky.

9 years, 3 months ago (2011-08-29 20:09:54 UTC) #2

Change committed as 98717

Expand Messages | Collapse Messages