Issue 7792005: OOBE_DOMUI4 template applied

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7792005: OOBE_DOMUI4 template applied (Closed)

Created:
9 years, 3 months ago by glotov

Modified:
9 years, 3 months ago

Reviewers:
kenmoore, Nikita (slow), kenmoore

CC:
chromium-reviews, arv (Not doing code reviews)

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

OOBE_DOMUI4 template applied BUG=chromium-os:19173 TEST=manual Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98816

Patch Set 1 #

Patch Set 2 : move header text (product name + header) 1px lower #

Patch Set 3 : fix #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+15 lines, -11 lines)			Patch
	M	chrome/browser/resources/chromeos/login/oobe.css	View	1 2	2 chunks	+14 lines, -8 lines	0 comments	Download
	M	chrome/browser/resources/chromeos/login/oobe.html	View		1 chunk	+1 line, -3 lines	0 comments	Download

Messages

Total messages: 6 (0 generated)

Expand Messages | Collapse Messages

glotov

Please see the resulting screenshots on my device here: http://www.corp.google.com/~glotov/1.png http://www.corp.google.com/~glotov/2.png

9 years, 3 months ago (2011-08-29 19:07:08 UTC) #1

Nikita (slow)

nit: referencing incorrect issue #. Correct one is 19173

9 years, 3 months ago (2011-08-30 07:41:49 UTC) #2

Nikita (slow)

Please move header text (product name + header) 1px lower.

9 years, 3 months ago (2011-08-30 07:54:06 UTC) #3

glotov

Done, please have a look again: http://www.corp.google.com/~glotov/1a.png http://www.corp.google.com/~glotov/2a.png

9 years, 3 months ago (2011-08-30 14:24:38 UTC) #4

kenmoore_google.com

9 years, 3 months ago (2011-08-30 16:25:07 UTC) #6

Yup, right on.

On Tue, Aug 30, 2011 at 8:04 AM, <nkostylev@chromium.org> wrote:

> LGTM
>
>
>
http://codereview.chromium.**org/7792005/<http://codereview.chromium.org/7792...
>

Expand Messages | Collapse Messages