Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(441)

Issue 7791031: Move the otr profile into its own .cc file. Like what was done with the (Closed)

Created:
9 years, 3 months ago by TVL
Modified:
9 years, 3 months ago
Reviewers:
Miranda Callahan
CC:
chromium-reviews
Visibility:
Public.

Description

Move the otr profile into its own .cc file. Like what was done with the profile io sources. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98966

Patch Set 1 #

Patch Set 2 : '' #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -805 lines) Patch
A + chrome/browser/profiles/off_the_record_profile_impl.cc View 1 3 chunks +0 lines, -148 lines 0 comments Download
M chrome/browser/profiles/profile.cc View 3 chunks +1 line, -656 lines 0 comments Download
M chrome/chrome_browser.gypi View 2 chunks +2 lines, -1 line 0 comments Download

Messages

Total messages: 2 (0 generated)
TVL
I didn't try to trim the included headers too much since the try bots are ...
9 years, 3 months ago (2011-08-30 17:22:22 UTC) #1
Miranda Callahan
9 years, 3 months ago (2011-08-31 09:09:53 UTC) #2
On 2011/08/30 17:22:22, TVL wrote:
> I didn't try to trim the included headers too much since the try bots are
about
> the only way i have to fully validate this.

Hallelujah, LGTM. I should have done this months ago.

Powered by Google App Engine
This is Rietveld 408576698