Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(405)

Unified Diff: chrome/browser/sessions/base_session_service.cc

Issue 7791029: When the user navigates to the home page, make sure to set the RLZ string (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src/
Patch Set: Adressing review comments Created 9 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/sessions/base_session_service.cc
===================================================================
--- chrome/browser/sessions/base_session_service.cc (revision 98807)
+++ chrome/browser/sessions/base_session_service.cc (working copy)
@@ -177,6 +177,9 @@
WriteStringToPickle(pickle, &bytes_written, max_state_size,
entry.referrer().is_valid() ? entry.referrer().spec() : std::string());
+ WriteStringToPickle(pickle, &bytes_written, max_state_size,
sky 2011/08/30 20:16:33 Add test coverage of this.
Roger Tawa OOO till Jul 10th 2011/08/31 20:14:01 Done.
+ entry.extra_headers());
+
// Adding more data? Be sure and update TabRestoreService too.
return new SessionCommand(command_id, pickle);
}
@@ -225,9 +228,17 @@
// the "referrer" property was added after type_mask to the written
// stream. As such, we don't fail if it can't be read.
std::string referrer_spec;
- pickle->ReadString(&iterator, &referrer_spec);
+ bool has_referrer = pickle->ReadString(&iterator, &referrer_spec);
if (!referrer_spec.empty())
navigation->referrer_ = GURL(referrer_spec);
+
+ if (has_referrer) {
+ // the "extra_headers" property was added after referrer to the written
+ // stream. As such, we don't fail if it can't be read.
+ std::string extra_headers;
+ pickle->ReadString(&iterator, &extra_headers);
+ navigation->set_extra_headers(extra_headers);
+ }
}
navigation->virtual_url_ = GURL(url_spec);

Powered by Google App Engine
This is Rietveld 408576698