Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(829)

Issue 7791022: Support Romaja key layout. (Closed)

Created:
9 years, 3 months ago by Seigo Nonaka
Modified:
9 years, 3 months ago
CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb
Visibility:
Public.

Description

Support Romaja key layout. BUG=chromium-os:15192 TEST=manually done(x86-generic, qemu) Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98947

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+6 lines, -1 line) Patch
M chrome/app/generated_resources.grd View 1 chunk +4 lines, -0 lines 0 comments Download
M chrome/browser/chromeos/language_preferences.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/chromeos/language_preferences.cc View 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Seigo Nonaka
9 years, 3 months ago (2011-08-30 10:16:56 UTC) #1
Yusuke Sato
On 2011/08/30 10:16:56, nona1 wrote: LGTM Is this for R15?
9 years, 3 months ago (2011-08-31 06:42:55 UTC) #2
Seigo Nonaka
Thank you for your review! I think it is OK to integrate into R15 even ...
9 years, 3 months ago (2011-08-31 07:47:55 UTC) #3
Yusuke Sato
ok, then let's submit it today. On 2011/08/31 07:47:55, nona1 wrote: > Thank you for ...
9 years, 3 months ago (2011-08-31 07:52:32 UTC) #4
commit-bot: I haz the power
9 years, 3 months ago (2011-08-31 09:15:05 UTC) #5
Change committed as 98947

Powered by Google App Engine
This is Rietveld 408576698