Issue 7791020: Fix localized "platform" message for non-8bit languages

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7791020: Fix localized "platform" message for non-8bit languages (Closed)

Created:
9 years, 3 months ago by kochi

Modified:
9 years, 3 months ago

Reviewers:
whywhat

CC:
chromium-reviews, davemoore+watch_chromium.org, stevenjb, nkostylev+cc_chromium.org, rharrison

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Fix localized "platform" message for non-8bit languages Now we use localized string for "platform", we should not assume the text is encoded in ASCII. To test this, manually change the UI to a non-latin language (e.g. Japanese) and see if any irregular font is not displayed. Webui login screen is also affected. BUG=chromium-os:19822 TEST=manually Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98911

Patch Set 1 #

Total comments: 2

Patch Set 2 : hange from ASCIIToWide to UTF8ToWide too for boottime string. #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+4 lines, -4 lines)			Patch
	M	chrome/browser/chromeos/login/background_view.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download
	M	chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc	View	1	1 chunk	+2 lines, -2 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

whywhat

LGTM http://codereview.chromium.org/7791020/diff/1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right): http://codereview.chromium.org/7791020/diff/1/chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc#newcode93 chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:93: base::StringValue id_value(ASCIIToUTF16(id)); nit: Should we use UTF8ToUTF16 there ...

9 years, 3 months ago (2011-08-30 08:27:42 UTC) #2

kochi

9 years, 3 months ago (2011-08-30 08:37:12 UTC) #3

Thanks for your quick review!

http://codereview.chromium.org/7791020/diff/1/chrome/browser/ui/webui/chromeo...
File chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc (right):

http://codereview.chromium.org/7791020/diff/1/chrome/browser/ui/webui/chromeo...
chrome/browser/ui/webui/chromeos/login/core_oobe_handler.cc:93:
base::StringValue id_value(ASCIIToUTF16(id));
On 2011/08/30 08:27:42, whywhat wrote:
> nit: Should we use UTF8ToUTF16 there too to be consistent and forget about
ASCII
> altogether?

Done.

Expand Messages | Collapse Messages