Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(27)

Issue 7791019: MIPS: Added ASSERTs to BranchShort to detect bad use of 'at' register. (Closed)

Created:
9 years, 3 months ago by Paul Lind
Modified:
9 years, 3 months ago
Reviewers:
Yang
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Added ASSERTs to BranchShort to detect bad use of 'at' register. Make sure 'at' and an immediate operand can't be used together in cases where 'at' would be overwritten by li. BUG= TEST= Committed: http://code.google.com/p/v8/source/detail?r=9072

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -0 lines) Patch
M src/mips/macro-assembler-mips.cc View 9 chunks +10 lines, -0 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
Paul Lind
Yang - this patch caught the bad use of 'at' register in our port of ...
9 years, 3 months ago (2011-08-30 07:04:45 UTC) #1
Yang
On 2011/08/30 07:04:45, Paul Lind wrote: > Yang - this patch caught the bad use ...
9 years, 3 months ago (2011-08-30 16:15:25 UTC) #2
Yang
9 years, 3 months ago (2011-08-30 16:15:35 UTC) #3
On 2011/08/30 16:15:25, Yang wrote:
> On 2011/08/30 07:04:45, Paul Lind wrote:
> > Yang - this patch caught the bad use of 'at' register in our port of your
> string
> > slices commit.
> 
> LGTM.

Landed.

Powered by Google App Engine
This is Rietveld 408576698