Issue 7791004: linux: delete code that worked around gtk <2.18

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7791004: linux: delete code that worked around gtk <2.18 (Closed)

Created:
9 years, 3 months ago by Evan Martin

Modified:
9 years, 3 months ago

Reviewers:
tony, James Su, Elliot Glaysher, Evan Stade

CC:
chromium-reviews, joi+watch-content_chromium.org, darin-cc_chromium.org, dhollowa, jam, brettw-cc_chromium.org

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

linux: delete code that worked around gtk <2.18 We now depend on GTK 2.18, and in fact we've been infobaring users who don't have it informing them that Chrome will stop working. Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98732

Patch Set 1 #

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+6 lines, -160 lines)			Patch
M	chrome/browser/browser_main.cc	View	1 chunk	+0 lines, -5 lines	0 comments	Download
M	chrome/browser/printing/print_dialog_gtk.cc	View	2 chunks	+0 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/gtk/global_bookmark_menu.cc	View	3 chunks	+6 lines, -43 lines	0 comments	Download
M	chrome/browser/ui/gtk/gtk_util.cc	View	3 chunks	+0 lines, -23 lines	0 comments	Download
M	chrome/browser/ui/gtk/menu_gtk.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	content/browser/renderer_host/gtk_key_bindings_handler.cc	View	7 chunks	+0 lines, -37 lines	0 comments	Download
M	views/controls/combobox/native_combobox_gtk.cc	View	1 chunk	+0 lines, -4 lines	0 comments	Download
M	views/controls/menu/native_menu_gtk.cc	View	2 chunks	+0 lines, -13 lines	0 comments	Download
M	webkit/glue/webcursor_gtk.cc	View	3 chunks	+0 lines, -27 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

Evan Martin

wide CC list because I touched a bunch of different files. PTAL, it's a small ...

9 years, 3 months ago (2011-08-29 17:52:21 UTC) #1

<3 LGTM

Expand Messages | Collapse Messages