Issue 7790024: Look in out/ as well as xcodebuild/ for mac, in case the user is using the make build.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7790024: Look in out/ as well as xcodebuild/ for mac, in case the user is using the make build. (Closed)

Created:
9 years, 3 months ago by kkania

Modified:
9 years, 3 months ago

Reviewers:
Nirnimesh

CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey

Base URL:
svn://svn.chromium.org/chrome/trunk/src

Visibility:
Public.

Description

Look in out/ as well as xcodebuild/ for mac, in case the user is using the make build. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98953

Patch Set 1 #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+13 lines, -20 lines)			Patch
	M	chrome/test/pyautolib/pyauto_paths.py	View		1 chunk	+13 lines, -20 lines	1 comment	Download

Messages

Total messages: 2 (0 generated)

Expand Messages | Collapse Messages

Nirnimesh

9 years, 3 months ago (2011-08-30 16:49:11 UTC) #2

LGTM

http://codereview.chromium.org/7790024/diff/1/chrome/test/pyautolib/pyauto_pa...
File chrome/test/pyautolib/pyauto_paths.py (right):

http://codereview.chromium.org/7790024/diff/1/chrome/test/pyautolib/pyauto_pa...
chrome/test/pyautolib/pyauto_paths.py:29: 'darwin': ['xcodebuild', 'out'],
reverse the order? 'out', 'xcodebuild'

Expand Messages | Collapse Messages