Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(253)

Issue 7790024: Look in out/ as well as xcodebuild/ for mac, in case the user is using the make build. (Closed)

Created:
9 years, 3 months ago by kkania
Modified:
9 years, 3 months ago
Reviewers:
Nirnimesh
CC:
chromium-reviews, Nirnimesh, John Grabowski, anantha, dyu1, Paweł Hajdan Jr., dennis_jeffrey
Visibility:
Public.

Description

Look in out/ as well as xcodebuild/ for mac, in case the user is using the make build. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98953

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+13 lines, -20 lines) Patch
M chrome/test/pyautolib/pyauto_paths.py View 1 chunk +13 lines, -20 lines 1 comment Download

Messages

Total messages: 2 (0 generated)
kkania
9 years, 3 months ago (2011-08-30 11:35:52 UTC) #1
Nirnimesh
9 years, 3 months ago (2011-08-30 16:49:11 UTC) #2
LGTM

http://codereview.chromium.org/7790024/diff/1/chrome/test/pyautolib/pyauto_pa...
File chrome/test/pyautolib/pyauto_paths.py (right):

http://codereview.chromium.org/7790024/diff/1/chrome/test/pyautolib/pyauto_pa...
chrome/test/pyautolib/pyauto_paths.py:29: 'darwin': ['xcodebuild', 'out'],
reverse the order? 'out', 'xcodebuild'

Powered by Google App Engine
This is Rietveld 408576698