Issue 7790020: Cleanup: Convert PrintPreviewTabController to use TabContentsWrapper.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 7790020: Cleanup: Convert PrintPreviewTabController to use TabContentsWrapper. (Closed)

Created:
9 years, 3 months ago by Lei Zhang

Modified:
9 years, 3 months ago

Reviewers:
Avi (use Gerrit), kmadhusu

CC:
chromium-reviews, Avi (use Gerrit), brettw-cc_chromium.org

Base URL:
svn://chrome-svn/chrome/trunk/src/

Visibility:
Public.

Description

Cleanup: Convert PrintPreviewTabController to use TabContentsWrapper. BUG=none TEST=none Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98857

Patch Set 1 : '' #

Total comments: 1

Created: 9 years, 3 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+206 lines, -181 lines)			Patch
M	chrome/browser/printing/background_printing_manager.cc	View	2 chunks	+6 lines, -7 lines	0 comments	Download
M	chrome/browser/printing/print_preview_message_handler.h	View	2 chunks	+4 lines, -1 line	1 comment	Download
M	chrome/browser/printing/print_preview_message_handler.cc	View	8 chunks	+21 lines, -23 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.h	View	3 chunks	+19 lines, -19 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller.cc	View	11 chunks	+59 lines, -58 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_browsertest.cc	View	13 chunks	+17 lines, -13 lines	0 comments	Download
M	chrome/browser/printing/print_preview_tab_controller_unittest.cc	View	11 chunks	+24 lines, -17 lines	0 comments	Download
M	chrome/browser/printing/print_view_manager.cc	View	1 chunk	+6 lines, -4 lines	0 comments	Download
M	chrome/browser/ui/browser.cc	View	1 chunk	+1 line, -1 line	0 comments	Download
M	chrome/browser/ui/tab_contents/tab_contents_wrapper.h	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.h	View	3 chunks	+4 lines, -2 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_handler.cc	View	13 chunks	+31 lines, -30 lines	0 comments	Download
M	chrome/browser/ui/webui/print_preview_ui_unittest.cc	View	4 chunks	+13 lines, -6 lines	0 comments	Download

Messages

Total messages: 3 (0 generated)

Expand Messages | Collapse Messages

kmadhusu

9 years, 3 months ago (2011-08-30 21:00:01 UTC) #3

LGTM with a style nit.

http://codereview.chromium.org/7790020/diff/34/chrome/browser/printing/print_...
File chrome/browser/printing/print_preview_message_handler.h (right):

http://codereview.chromium.org/7790020/diff/34/chrome/browser/printing/print_...
chrome/browser/printing/print_preview_message_handler.h:35: // Helper function
to return the TabContentsWrapper for tab_contents().
nit: Add a blank line before this.

Expand Messages | Collapse Messages