Clean up plugin constants

Clean up flash plugin constants, put them in a single place.


BUG=none
TEST=none
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98902

[jam, 2011-08-30 16:53:56]

http://codereview.chromium.org/7790013/diff/6001/webkit/plugins/plugin_consta...
File webkit/plugins/plugin_constants.h (right):

http://codereview.chromium.org/7790013/diff/6001/webkit/plugins/plugin_consta...
webkit/plugins/plugin_constants.h:16: extern const char kPDFPluginName[];
can we only move flash, and keep pdf/nacl/remoting? these belong in the chrome
layer, since the webkit layer doesn't know anything about these chrome features

[cpu_(ooo_6.6-7.5), 2011-08-30 17:21:37]

These constants are mostly used when registering plugins with webkit. One thing
you might not have seen is that I am working towards making the webkit (our
webkit) plugin code not npapi specific.

Check http://codereview.chromium.org/7648017/

In particular :
http://codereview.chromium.org/7648017/diff/2035/webkit/plugins/webplugininfo.h


On 2011/08/30 16:53:56, John Abd-El-Malek wrote:
>
http://codereview.chromium.org/7790013/diff/6001/webkit/plugins/plugin_consta...
> File webkit/plugins/plugin_constants.h (right):
> 
>
http://codereview.chromium.org/7790013/diff/6001/webkit/plugins/plugin_consta...
> webkit/plugins/plugin_constants.h:16: extern const char kPDFPluginName[];
> can we only move flash, and keep pdf/nacl/remoting? these belong in the chrome
> layer, since the webkit layer doesn't know anything about these chrome
features

[jam, 2011-08-30 17:24:24]

sure, i think that's orthogonal though. i didn't mean it was because they
were npapi or pepper plugins. the issue is that webkit\plugins only knows
about base support for pepper or npapi. chrome has its own npapi/ppapi
plugins build using this support, but webkit shouldn't have to know details
about them (i.e. like how WebKit layer doesn't know about chrome)

On Tue, Aug 30, 2011 at 10:21 AM, <cpu@chromium.org> wrote:

> These constants are mostly used when registering plugins with webkit. One
> thing
> you might not have seen is that I am working towards making the webkit (our
> webkit) plugin code not npapi specific.
>
> Check
http://codereview.chromium.**org/7648017/<http://codereview.chromium.org/7648...
>
> In particular :
> http://codereview.chromium.**org/7648017/diff/2035/webkit/**
>
plugins/webplugininfo.h<http://codereview.chromium.org/7648017/diff/2035/webkit/plugins/webplugininfo.h>
>
>
>
> On 2011/08/30 16:53:56, John Abd-El-Malek wrote:
>
> http://codereview.chromium.**org/7790013/diff/6001/webkit/**
>
plugins/plugin_constants.h<http://codereview.chromium.org/7790013/diff/6001/webkit/plugins/plugin_constants.h>
>
>> File webkit/plugins/plugin_**constants.h (right):
>>
>
>
> http://codereview.chromium.**org/7790013/diff/6001/webkit/**
>
plugins/plugin_constants.h#**newcode16<http://codereview.chromium.org/7790013/diff/6001/webkit/plugins/plugin_constants.h#newcode16>
>
>> webkit/plugins/plugin_**constants.h:16: extern const char
>> kPDFPluginName[];
>> can we only move flash, and keep pdf/nacl/remoting? these belong in the
>> chrome
>> layer, since the webkit layer doesn't know anything about these chrome
>>
> features
>
>
>
>
http://codereview.chromium.**org/7790013/<http://codereview.chromium.org/7790...
>

[cpu_(ooo_6.6-7.5), 2011-08-30 20:06:09]

code changed, please look again.

[jam, 2011-08-30 20:32:55]

lgtm