Fixed extension icon source handling of component extensions.

Fixed extension icon source handling of component extensions.

BUG=chromium-os:18999
TEST=make sure file browser web app icon shows up on NTP page
Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=98930

[dgozman, 2011-08-30 10:45:32]

LGTM with comment addressed

http://codereview.chromium.org/7790002/diff/1/chrome/browser/ui/webui/extensi...
File chrome/browser/ui/webui/extension_icon_source.cc (right):

http://codereview.chromium.org/7790002/diff/1/chrome/browser/ui/webui/extensi...
chrome/browser/ui/webui/extension_icon_source.cc:204: if (relative_path ==
bm_resource_path) {
Shouldn't you also normalize |relative_path| before comparing?

relative_path.NormalizeWindowsPathSeparators()

Or even don't normalize both?

[zel, 2011-08-30 22:16:27]

http://codereview.chromium.org/7790002/diff/1/chrome/browser/ui/webui/extensi...
File chrome/browser/ui/webui/extension_icon_source.cc (right):

http://codereview.chromium.org/7790002/diff/1/chrome/browser/ui/webui/extensi...
chrome/browser/ui/webui/extension_icon_source.cc:204: if (relative_path ==
bm_resource_path) {
On 2011/08/30 10:45:32, dgozman wrote:
> Shouldn't you also normalize |relative_path| before comparing?
> 
> relative_path.NormalizeWindowsPathSeparators()
> 
> Or even don't normalize both?

i don't think we need to do that that with relative_path since it's cooked
earlier on the stack here

[zel, 2011-08-30 22:20:24]

adding jstritar@